[VEG-2359] - drop support for password based basic auth #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romeodemeteriojr
commented
Jul 3, 2024
| } else if (ZENDESK_EMAIL && ZENDESK_PASSWORD) { | ||
| return this.createBasicAuthToken(ZENDESK_EMAIL, ZENDESK_PASSWORD) | ||
| return this.createBasicAuthToken(ZENDESK_EMAIL, ZENDESK_PASSWORD, SecretType.PASSWORD) |
There was a problem hiding this comment.
This check is kept for those users that still only have ZENDESK_PASSWORD in their systems (e.g. cicd, local, etc) to properly fire an error that it is not supported.
romeodemeteriojr
force-pushed
the
rdemeterio/VEG-2359
branch
2 times, most recently
from
bcfde4f to
fda2298
Compare
EmilyBie
reviewed
Jul 4, 2024
romeodemeteriojr
force-pushed
the
rdemeterio/VEG-2359
branch
from
fda2298 to
dcb4647
Compare
EmilyBie
approved these changes
Jul 4, 2024
anushkafka
reviewed
Jul 4, 2024
anushkafka
approved these changes
Jul 4, 2024
romeodemeteriojr
force-pushed
the
rdemeterio/VEG-2359
branch
2 times, most recently
from
e52b660 to
dcb4647
Compare
luis-almeida
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Does it make sense to keep the -i flag on the zcli login command?
It seems like it will be the only possible option as browser login will be impossible from now on (?)
👍🏼 from Vikings nonetheless!
👋 @luis-almeida, yes we are keeping the |
romeodemeteriojr
force-pushed
the
rdemeterio/VEG-2359
branch
10 times, most recently
from
1eac8af to
6b67aa8
Compare
Shengming-Yan
approved these changes
Jul 10, 2024
To keep things generic. However, we can't change the keytar interface as these fucntion names are library requirements.
When ZENDESK_DOMAIN and ZENDESK_SUBDOMAIN are not set, domain is taken from an active profile. This works just fine. However when domain is taken from the env, the request sends a corrupted payload and server responds with 400. This is a workaround to make the function behave consistently whether env or profile is being used.
romeodemeteriojr
force-pushed
the
rdemeterio/VEG-2359
branch
from
6b67aa8 to
f1bb545
Compare
romeodemeteriojr
force-pushed
the
rdemeterio/VEG-2359
branch
from
8979f21 to
5672642
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic authentication with password is no longer supported as per doc, channel.
This PR drops support for login with password, now replaced with api token.
There is also a fix added that addresses inconsistent behaviour of zcli when envs are used for auth. See commit 46e478a
Screenshot
Screen.Recording.2024-07-04.at.9.56.06.AM.mov
References
JIRA: https://zendesk.atlassian.net/browse/VEG-2359
Commits
b94702fchore: ignore intellij files415b5e1feat: change login to use api tokene4eb869fix: fix unit and functional testse0c2aaafeat: replace term password with secret To keep things generic. However, we can't change the keytar interface as these fucntion names are library requirements.2d3fcbblint: fix lint errors97f6ce9feat: update help message to refer only the api token7d1f234fix: inconsistent behaviour when ZENDESK_DOMAIN env is set When ZENDESK_DOMAIN and ZENDESK_SUBDOMAIN are not set, domain is taken from an active profile. This works just fine. However when domain is taken from the env, the request sends a corrupted payload and server responds with 400. This is a workaround to make the function behave consistently whether env or profile is being used.ab1788btest: fix test to actually test env & profile5672642test: separate request creation from execution for easier testingDetail
Checklist