Doc

CONTRIBUTING.md

@@ -10,18 +10,22 @@
 
 ### Test suite
 
-```sh
-# TODO: Update CONTRIBUTING
-docker-compose up
-docker run -it --rm -v $(pwd):/app zendesk_api_client_php-app bash
-```
-
 The test suite is run via phpunit. Note that these are all live tests that must be run targeted at a real Zendesk instance. Credentials can be provided by setting the environment variables in phpunit.xml; a sample is provided at phpunit.xml.dist.
 
 To run the unit tests: `vendor/bin/phpunit --testsuite "Zendesk API Unit Test Suites"`
 
 To run the live tests: `vendor/bin/phpunit --testsuite "Zendesk API Live Test Suites"`
 
+### Docker
+
+If you prefer to use Docker for running your tests:
+
+```sh
+# Run the specs
+docker-compose up
+# Or open a shell in the container
+docker run -it --rm -v $(pwd):/app zendesk_api_client_php-app bash
+```
 
 ## Coding Standard
 

README.md

@@ -18,8 +18,7 @@ This client **only** supports Zendesk's API v2.  Please see our [API documentati
 
 ## Requirements
 
-* TODO: Update README
-* PHP 5.5+
+* PHP 7.4+
 
 ## Installation
 

src/Zendesk/API/Resources/Chat/Apps.php

@@ -14,8 +14,7 @@ class Apps extends ResourceAbstract
     /**
      * @var string
      */
-    protected $apiBasePath = 'api/chat/';
-    // TODO: api/v2
+    protected $apiBasePath = '';
 
     /**
      * {@inheritdoc}

tests/Zendesk/API/UnitTests/Core/AuthTest.php

@@ -20,7 +20,7 @@ class AuthTest extends BasicTest
      */
     public function testAnonymousAccess()
     {
-        $this->markTestSkipped('CBP TODO mocking');
+        $this->markTestSkipped('Broken in PHP 7.4 (mocking)');
 
         // mock client
         $client = $this

tests/Zendesk/API/UnitTests/Embeddable/ConfigSetsTest.php

@@ -40,7 +40,6 @@ public function testUpdate()
 
         $this->assertEndpointCalled(function () use ($params, $id) {
             $this->client->embeddable->configSets()->update($id, $params);
-            // TODO: Verify calls work
         }, "api/v2/embeddable/api/config_sets/{$id}.json", 'PUT', [
             'apiBasePath' => '/',
             'postFields' => ['config_set' => $params],

tests/Zendesk/API/UnitTests/Exceptions/ApiResponseExceptionTest.php

@@ -12,7 +12,7 @@ class ApiResponseExceptionTest extends BasicTest
      */
     public function testPreviousException()
     {
-        $this->markTestSkipped('CBP TODO mocking');
+        $this->markTestSkipped('Broken in PHP 7.4 (mocking)');
 
         $message = 'The previous exception was not passed to ApiResponseException';
         $mockException = $this

tests/Zendesk/API/UnitTests/HttpTest.php

@@ -19,7 +19,7 @@ class HttpTest extends BasicTest
      */
     public function testOriginalRequestExceptionIsPreserved()
     {
-        $this->markTestSkipped('CBP TODO mocking');
+        $this->markTestSkipped('Broken in PHP 7.4 (mocking)');
         $faker = Factory::create();
 
         $exceptionMessage = $faker->sentence;

tests/Zendesk/API/UnitTests/Middleware/RetryHandlerTest.php

@@ -55,7 +55,6 @@ public function requestExceptionsProvider()
         return [
             [ServerException::class, true],
             [ClientException::class, true],
-            // TODO: [ConnectException::class, false],
             [TooManyRedirectsException::class, false]
         ];
     }