AppsTest#testInstall

zendesk · Oct 9, 2023 · b172ff4 · b172ff4
1 parent 83cb7b2
commit b172ff4
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 17 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -9,7 +9,7 @@ services:
       - vendor:/app/vendor
     command: vendor/bin/phpunit --testsuite "Zendesk API Unit Test Suites"
     # command: vendor/bin/phpunit --debug --filter testCreateNeedsTicketId tests/Zendesk/API/UnitTests/Core/SatisfactionRatingsTest.php
-    # command: vendor/bin/phpunit --debug tests/Zendesk/API/UnitTests/Exceptions/ApiResponseExceptionTest.php
+    # command: vendor/bin/phpunit --debug tests/Zendesk/API/UnitTests/Chat/AppsTest.php
 
 volumes:
   vendor:
diff --git a/src/Zendesk/API/Resources/Chat/Apps.php b/src/Zendesk/API/Resources/Chat/Apps.php
@@ -15,6 +15,7 @@ class Apps extends ResourceAbstract
      * @var string
      */
     protected $apiBasePath = 'api/chat/';
+    // TODO: api/v2
 
     /**
      * {@inheritdoc}

diff --git a/tests/Zendesk/API/UnitTests/BasicTest.php b/tests/Zendesk/API/UnitTests/BasicTest.php
@@ -185,17 +185,18 @@ public function assertRequestIs($options, $index = 0)
 
         if (isset($options['apiBasePath'])) {
             $this->assertSame(
-                0,
-                strpos($request->getUri()->getPath(), $options['apiBasePath']),
-                "Failed asserting that the API basepath is {$options['apiBasePath']}"
+                0, strpos($request->getUri()->getPath(), $options['apiBasePath']),
+                "Failed asserting apiBasePath: expected: {$options['apiBasePath']}, actual: {$request->getUri()->getPath()}"
             );
         }
 
         if (isset($options['endpoint'])) {
             // Truncate the base path from the target, this was added since the existing usage pattern for
             // $options['endpoint'] does not include the api/v2 base path
             $endpoint = preg_replace('/^' . preg_quote($options['apiBasePath'], '/') . '/', '', $request->getUri()->getPath());
-            $this->assertEquals($options['endpoint'], $endpoint);
+            $this->assertEquals(
+                $options['endpoint'], $endpoint,
+                "Failed asserting endpoint: expected: {$options['endpoint']}, actual: {$endpoint}");
         }
 
         if (isset($options['queryParams'])) {

diff --git a/tests/Zendesk/API/UnitTests/Chat/AppsTest.php b/tests/Zendesk/API/UnitTests/Chat/AppsTest.php
@@ -12,19 +12,10 @@ class AppsTest extends BasicTest
      */
     public function testInstall()
     {
-        $this->markTestSkipped('CBP TODO assert');
-        // 1) Zendesk\API\UnitTests\Chat\AppsTest::testInstall
-        // Failed asserting that the API basepath is /api/chat/
-        // Failed asserting that false is identical to 0.
-        // /app/tests/Zendesk/API/UnitTests/BasicTest.php:190
-        // /app/tests/Zendesk/API/UnitTests/BasicTest.php:120
-        // /app/tests/Zendesk/API/UnitTests/BasicTest.php:233
-        // /app/tests/Zendesk/API/UnitTests/Chat/AppsTest.php:31
-        // phpvfscomposer:///app/vendor/phpunit/phpunit/phpunit:35
-
         $faker = Factory::create();
         $postFields = [
             'app_id'   => $faker->numberBetween(1),
+            'product_name' => 'chat',
             'settings' =>
             [
                 'name'      => $faker->word,
@@ -36,7 +27,7 @@ public function testInstall()
             $this->client->chat->apps()->install($postFields);
         }, 'apps/installations.json', 'POST', [
             'postFields' => $postFields,
-            'apiBasePath' => '/api/chat/',
+            'apiBasePath' => '/api/v2/'
         ]);
     }
 }
diff --git a/tests/Zendesk/API/UnitTests/Core/SatisfactionRatingsTest.php b/tests/Zendesk/API/UnitTests/Core/SatisfactionRatingsTest.php
@@ -40,7 +40,6 @@ function () use ($ticketId, $postParams) {
         );
     }
 
-
     /**
      * Test the create method requires a ticket id
      */