Delete CbpStrategy sortParams()

CBP_UPGRADE_GUIDE.md

@@ -39,7 +39,7 @@ Note the query parameters change in these two URL examples:
 
 ### CBP ordering
 
-When moving from OBP to CBP sorting params change as well:
+When moving from OBP to CBP sorting params _may_ change as well:
 
 - From: `?sort_name=updated_at&sort_order=desc`
 - To: `sort=-updated_at`

README.md

@@ -155,6 +155,8 @@ foreach ($iterator as $ticket) {
   * Refer to the docs for details, including allowed sort fields
 * Combine everything: `$params = ['page[size]' => 2, 'sort' => 'updated_at', 'extra' => 'param'];`
 
+**Note**: Refer to the documentation for the correct params for sorting with the pagination type you're using.
+
 ##### Iterator API call response
 
 The latest response is exposed in the iterator at `$iterator->latestResponse()`. This could come handy for debugging.

tests/Zendesk/API/UnitTests/Traits/Utility/PaginationIteratorTest.php

@@ -125,23 +125,6 @@ public function testFetchesCbpWithParams()
         ], $mockTickets->params);
     }
 
-    public function testCorrectsParamsToCbp()
-    {
-        $mockTickets = new MockResource('tickets', [
-            [['id' => 1], ['id' => 2]],
-            [['id' => 3], ['id' => 4]]
-        ]);
-        $strategy = new CbpStrategy('tickets', ['per_page' => 2, 'sort_by' => 'id', 'sort_order' => 'desc']);
-        $iterator = new PaginationIterator($mockTickets, $strategy, 'findAll');
-
-        iterator_to_array($iterator);
-
-        $this->assertEquals([
-            'sort' => '-id',
-            'page[size]' => 2, 'page[after]' => 'cursor_for_next_page'
-        ], $mockTickets->params);
-    }
-
     public function testFetchesSinglePageWithParams()
     {
         $resultsKey = 'results';