Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow async query parameter for creating tickets #302

Merged
merged 6 commits into from
Dec 23, 2016
Merged

Conversation

miogalang
Copy link
Contributor

/cc @zendesk/mintegrations

Description

Allows the creation of tickets asynchronously.
ref: https://developer.zendesk.com/rest_api/docs/core/tickets#create-ticket-asynchronously

References

  • JIRA:

Risks

  • medium. Ticket creation mught fail

Copy link
Contributor

@samgavinio samgavinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some super minor stuff, 👍

@@ -178,6 +178,26 @@ public function testCreateWithAttachment()
'postFields' => $postFields,
]);
}

/**
* Tests if the client can call and build the create ticket witch attachment endpoint and initiate the file upload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description doesn't seem to match the test.

* @return \stdClass | null
* @param array $options
* @return null|\stdClass
* @throws \Zendesk\API\Exceptions\AuthException
* @throws Exceptions\ApiResponseException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be changed to \Zendesk\API\Exceptions\ApiResponseException?

@miogalang
Copy link
Contributor Author

/cc @FuzzyTree

@miogalang miogalang merged commit 89126f5 into master Dec 23, 2016
@miogalang miogalang deleted the mio/tickets-async branch December 23, 2016 07:33
lyrixx pushed a commit to lyrixx/zendesk_api_client_php that referenced this pull request Jun 24, 2019
Allow async query parameter for creating tickets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants