-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow async query parameter for creating tickets #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some super minor stuff, 👍
@@ -178,6 +178,26 @@ public function testCreateWithAttachment() | |||
'postFields' => $postFields, | |||
]); | |||
} | |||
|
|||
/** | |||
* Tests if the client can call and build the create ticket witch attachment endpoint and initiate the file upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description doesn't seem to match the test.
* @return \stdClass | null | ||
* @param array $options | ||
* @return null|\stdClass | ||
* @throws \Zendesk\API\Exceptions\AuthException | ||
* @throws Exceptions\ApiResponseException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be changed to \Zendesk\API\Exceptions\ApiResponseException
?
/cc @FuzzyTree |
Allow async query parameter for creating tickets
/cc @zendesk/mintegrations
Description
Allows the creation of tickets asynchronously.
ref: https://developer.zendesk.com/rest_api/docs/core/tickets#create-ticket-asynchronously
References
Risks