Validate the provided Zendesk subdomain #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manted
approved these changes
Apr 13, 2021
SmeegeSec
reviewed
Apr 13, 2021
- Each subdomain part must have a length no greater than 63. - Each subdomain part must begin and end with an alpha-numeric (i.e. letters [A-Za-z] or digits [0-9]). - Each subdomain part may contain hyphens (dashes), but may not begin or end with a hyphen.
SmeegeSec
approved these changes
Apr 14, 2021
veera
approved these changes
Apr 16, 2021
|
@thekindofme how about updating the meta in composer repo? There is still an old 2.2.10 version and cannot be updated. |
|
Seconded - could you update Packagist with the 2.2.11 release for Composer to pick up please? |
sanmai
added a commit
to sanmai/zendesk_api_client_php
that referenced
this pull request
Nov 16, 2021
|
Hey folks, if you would like to review a backport of this fix to the previous version in #477, please be my guest. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the provided Zendesk subdomain to be a valid subdomain in: