Fix PHP 8 introduced breaking change to call_user_func_array() #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call_user_func_array()
is used byHttpClient::getSideload(array $params = [])
, and since PHP 8^ introduced named arguments, the use of an associative array as arguments, will break the code since the array_merge does not support named arguments.The fix is changing this line:
zendesk_api_client_php/src/Zendesk/API/HttpClient.php
Line 441 in b451b74
To this: