CBP iterator for Users #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecoologic
commented
Oct 18, 2023
| $params['page[after]'] = $this->afterCursor; | ||
| } | ||
| $response = $this->resourcesRoot->findAll($params); | ||
| $this->page = array_merge($this->page, $response->{$this->resourcesKey}); |
There was a problem hiding this comment.
now using resourcesKey (eg: tickets or users) we can get the data in the response from the right place.
ecoologic
force-pushed
the
RED-1953-cbp
branch
from
1522f9f
to
c5016b9
Compare
ecoologic
commented
Oct 18, 2023
| */ | ||
| private $position = 0; | ||
|
|
||
| // TODO: page is actually growing every call, should be only one page (reset position) |
There was a problem hiding this comment.
currently up for debate. I'll update if we decide, in my next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using CBP for Tickets and Users. TicketIterator becoming CbpIterator.
PS: There's a major refactoring coming to accommodate OBP endpoints, this is a minor stepping stone. Most of the changes are renaming and extractions.