Red 1953 pagination #513
Merged
Red 1953 pagination #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
2a1362f
to
f50ff46
Compare
ecoologic
force-pushed
the
RED-1953-pagination
branch
2 times, most recently
from
ea8e02c
to
a1af75a
Compare
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
a1af75a
to
0842d6f
Compare
ecoologic
commented
Oct 25, 2023
| { | ||
| return new TicketsIterator($this); | ||
| } | ||
|
|
There was a problem hiding this comment.
moved into trait to make it generic to all resources.
ecoologic
force-pushed
the
RED-1953-pagination
branch
2 times, most recently
from
0da9b00
to
c4bd841
Compare
ecoologic
commented
Oct 26, 2023
|
|
||
| private function paginationStrategyClass() { | ||
| return ObpStrategy::class; | ||
| } |
There was a problem hiding this comment.
const are not available in traits in the current PHP version (7.4)
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
c4bd841
to
3856a8e
Compare
ecoologic
commented
Oct 26, 2023
|
|
||
| private function paginationStrategyClass() { | ||
| return CbpStrategy::class; | ||
| } |
There was a problem hiding this comment.
This will act as default
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
3856a8e
to
7ff5420
Compare
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
7ff5420
to
5994a59
Compare
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
4578878
to
4af18e5
Compare
ecoologic
force-pushed
the
RED-1953-pagination
branch
4 times, most recently
from
8b96def
to
2cca4bb
Compare
ecoologic
force-pushed
the
RED-1953-pagination
branch
from
2cca4bb
to
48ac3f6
Compare
ecoologic
commented
Oct 30, 2023
| @@ -8,6 +8,9 @@ services: | |||
| - .:/app | |||
| - vendor:/app/vendor | |||
| command: vendor/bin/phpunit --testsuite "Zendesk API Unit Test Suites" | |||
| # command: vendor/bin/phpunit tests/Zendesk/API/UnitTests/Traits/Utility/PaginationTest.php | |||
| # command: vendor/bin/phpunit tests/Zendesk/API/UnitTests/Core/TicketsTest.php | |||
| # command: vendor/bin/phpunit tests/Zendesk/API/UnitTests/Core/OrganizationMembershipsTest.php | |||
There was a problem hiding this comment.
I'll do some cleaning at the end, but these comments come useful to switch between tests.
fbvilela
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the solution that works with all types of pagination (obp / cbp / single page). Defaults to CBP.
** Update: I extracted the iterator in its own trait.