This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Implement fromRoute()
and getMatchedRoute()
#23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RouteResult::fromRoute()
expects aRoute
instance, and, optionally, the parameters matched during routing, and returns an instance representing a successful route match. The various getters, other thangetMatchedParams()
, then proxy to the underlyingRoute
instance.getMatchedRoute()
returns the matchedRoute
instance, allowing consumers to pull additional information from it, including the path, options, etc.This patch also deprecates
fromRouteMatch()
, as it becomes redundant when theRoute
instance is present.Finally, this patch would supercede #21 and fix #12, as the user could then perform the following to get the path:
(The user would also now be able to retrieve allowed methods for the given route, using the
getAllowedMethods()
method on either theRouteResult
or composedRoute
, making this solution more flexible.)This approach is completely backwards compatible, but, because it provides new functionality, would require a new minor version (1.3.0 is the target).