This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Raise exception in Route constructor when no HTTP methods provided #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routes _require_ one or more HTTP methods in order to be valid.
| @@ -160,6 +160,12 @@ public function getOptions() : array | |||
| */ | |||
| private function validateHttpMethods(array $methods) : array | |||
| { | |||
| if (empty($methods)) { | |||
There was a problem hiding this comment.
We can have here just ! $methods
There was a problem hiding this comment.
Considering the argument is typed as an array, this makes it more semantically clear that we're checking to see if we have an empty array.
There was a problem hiding this comment.
the result will be exactly the same and everywhere we are using just !, but fine - whatever you prefer, both works the same.
There was a problem hiding this comment.
I'm aware the results will be the same. Readability and intent are important, however!
| @@ -178,7 +178,7 @@ public function testCommonHttpMethodsAreExposedAsClassMethodsAndReturnRoutes($me | |||
| public function testCreatingHttpRouteMethodWithExistingPathButDifferentMethodCreatesNewRouteInstance() | |||
| { | |||
| $this->router->addRoute(Argument::type(Route::class))->shouldBeCalledTimes(2); | |||
| $route = $this->middleware->route('/foo', $this->noopMiddleware, []); | |||
| $route = $this->middleware->route('/foo', $this->noopMiddleware, ['POST']); | |||
There was a problem hiding this comment.
Maybe we should use RequestMethod::METHOD_POST (for consistency)
test/RouteTest.php
Outdated
| @@ -71,13 +71,13 @@ public function testRouteCanMatchMethod() | |||
|
|
|||
| public function testRouteHeadMethodIsNotAllowedByDefault() | |||
| { | |||
| $route = new Route('/foo', $this->noopMiddleware, []); | |||
| $route = new Route('/foo', $this->noopMiddleware, ['GET']); | |||
There was a problem hiding this comment.
also here and in following tests
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routes require one or more HTTP methods in order to be valid.