This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Optionally pass $options to actual router when generating URIs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm @DASPRiD changing an Either a major version need to be released if so. |
|
@DASPRiD since the changes this PR makes to |
michaelmoussa
changed the title
michaelmoussa
added a commit
that referenced
this pull request
Oct 4, 2016
michaelmoussa
added a commit
that referenced
this pull request
Oct 4, 2016
michaelmoussa
added a commit
that referenced
this pull request
Oct 4, 2016
michaelmoussa
added a commit
that referenced
this pull request
Oct 4, 2016
michaelmoussa
added a commit
that referenced
this pull request
Oct 4, 2016
|
Merged into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
zendframework/zend-expressive#307
zendframework/zend-expressive-helpers#9
What's still missing: the three router bridges which are in place still need to be updated to use the new
RuntimeConfigurableRouterInterface. I've also added an optionaloptionsarray to thegenerateUrimethod, which a router bridge may pass down to its actual router.If we need to maintain BC, I can find a way to handle that, but this is the easiest approach.