This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Support Recaptcha APIv2 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZendService_ReCaptcha supports v2 of the API which renders differently.
Ocramius
approved these changes
Feb 20, 2017
| @@ -35,7 +35,7 @@ | |||
| "zendframework/zend-text": "^2.6", | |||
| "zendframework/zend-validator": "^2.6", | |||
| "zendframework/zend-view": "^2.6.2", | |||
| "zendframework/zendservice-recaptcha": "*", | |||
There was a problem hiding this comment.
Wow, didn't know we still had the death-star-constraint O_O
Recaptcha API v2 generates much simpler HTML than API v1 did. Hence we can simplify the tests.
|
LGTM |
froschdesign
approved these changes
Feb 20, 2017
ReCaptcha automatically creates a hidden element called `g-recaptcha-response` for its response. If this element is not called that, then the required validation will fail unless we render a hidden element.
asgrim
approved these changes
Feb 22, 2017
weierophinney
approved these changes
Feb 22, 2017
| * Create the JS events used to bind the challenge and response values to the submitted form. | ||
| * No longer used with v2 of Recaptcha API | ||
| * | ||
| * @deprecated | ||
| * | ||
| * @param string $challengeId | ||
| * @param string $responseId | ||
| * @return string | ||
| */ | ||
| protected function renderJsEvents($challengeId, $responseId) |
There was a problem hiding this comment.
I'm wondering if we could just remove this entirely?
There was a problem hiding this comment.
My thought was that someone may have overridden & called the parent
There was a problem hiding this comment.
@akrabat Good point — as it's protected, likely should be kept. sigh
akrabat
added a commit
that referenced
this pull request
Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use zend-capchta:2.7.0 which require zendservice-recaptcha:3.0.0
From zend-form's point of view, we no longer need a hidden field or the JS. As a result,
renderHiddenInput()andrenderJsEvents()are now just stubbed out and marked deprecated.