This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fixed form hydration for forms with wrapped elements #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
approved these changes
May 9, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
|
Thanks, @scroach; merged to develop for release with 2.11.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the dependencies on a project which hasn't been updated in a while I stumbled upon a problem with form hydration.
When using a form with
setWrapElements(true);the methodbindValuesinFieldSetfails because it fetches the elements name with$name = $element->getName();This fails cause the name might be something like
myFormName[myFormElement]instead ofmyFormElementand it is not recognized.Prior to commit 82b0cdc the method simply used
foreach ($this->iterator as $name => $element) {which still works.Please correct me if I'm wrong but I think the current behaviour is wrong.
I've reverted the line and provided an additional unit test.