This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Element\DateTime format fix #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/Element/MonthTest.php
Outdated
| @@ -17,6 +17,7 @@ class MonthTest extends TestCase | |||
| public function testProvidesInputSpecificationThatIncludesValidatorsBasedOnAttributes() | |||
| { | |||
| $element = new MonthElement('foo'); | |||
| $element->setFormat('Y-m'); | |||
There was a problem hiding this comment.
The format setting is wrong, because the Month element has already this format. (See also #170)
There was a problem hiding this comment.
protected $format = self::DATETIME_FORMAT; is missing in Zend\Form\Element\Month
There was a problem hiding this comment.
Yeah I noticed that, I had to set the format due to the missing field. Was in kinda of a rush.
froschdesign
suggested changes
Jul 12, 2017
test/Element/MonthTest.php
Outdated
| @@ -17,6 +17,7 @@ class MonthTest extends TestCase | |||
| public function testProvidesInputSpecificationThatIncludesValidatorsBasedOnAttributes() | |||
| { | |||
| $element = new MonthElement('foo'); | |||
| $element->setFormat('Y-m'); | |||
There was a problem hiding this comment.
protected $format = self::DATETIME_FORMAT; is missing in Zend\Form\Element\Month
…onger set the format for the Element\Month.
froschdesign
approved these changes
Jul 12, 2017
|
Related to #168 |
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
Element\DateTime format fix
weierophinney
added a commit
that referenced
this pull request
Dec 6, 2017
|
Thanks, @Kwido |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static format is now being used rendering the set format useless.