This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Finalize zend-servicemanager and zend-eventmanager v3 forwards compatibility #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: ServiceManager and EventManager v2-v3 compatibility
Updated dependencies to stable, forwards-compatible versions. Additionally, removed zend-di and zend-mvc from the mix, as this version contained a test for a class in zend-mvc (wrong component!). zend-captcha and zend-session are removed when testing against v3 components as they are not yet forwards-compatible; tests against them are marked skipped when that occurs.
|
zend-eventmanager v2 compat is causing issues; will investigate. |
Added an env variable for specifying the hydrator version to use, and now vary the stdlib version based on the hydrator version, ensuring v2 variants are used consistently (with v1.1 of hydrator).
Updated all `triggerUntil` calls to use the `triggerEventUntil` syntax, to ensure both BC and FC (`triggerUntil()` in v2 uses the old signature, making it non-viable for code supporting both versions).
This patch updates the FormElementManager and HelperConfig to ensure backwards compatibility with v2. In addition, it removes code made obsolete by the final zend-servicemanager v3 version (specifically, auto invokables were re-introduced, and creation options are now present for classes mapped to the `InvokableFactory`).
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on #40 to do the following:
Initial testing locally shows all tests are running.