This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
On SMv2 only canonicalized aliases make sense #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $aliases = $r->getValue($this->manager); | ||
|
|
||
| foreach ($aliases as $name => $alias) { | ||
| $this->manager->get($name . ' '); |
There was a problem hiding this comment.
Quite expensive no? An assertion on lower casing should be sufficient I think. $this->assertSame(strtolower($name), $name);
There was a problem hiding this comment.
I found the bug because I was trying to get the element with the camel-cased key.
As such, the test should reflect the use case and treat the code in the best black-box way possible.
Checking the case of keys would be a total white-box test with no insight of why we are testing that way.
weierophinney
added a commit
that referenced
this pull request
May 3, 2016
On SMv2 only canonicalized aliases make sense
weierophinney
added a commit
that referenced
this pull request
May 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All aliases are checked canonicalized.
Non-canonicalized only aliases raise a missin-alias error.
Other non-canonicalized are useless.