This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
DateTimeFormatterStrategy could extract DateTimeImmutable aswell #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teTimeInterface` check
…teTimeInterface` Used `DateTime` mock instead of proper `DateTimeImmutable`
weierophinney
added a commit
that referenced
this pull request
Apr 30, 2018
DateTimeFormatterStrategy could extract DateTimeImmutable aswell
weierophinney
added a commit
that referenced
this pull request
Apr 30, 2018
weierophinney
added a commit
that referenced
this pull request
Apr 30, 2018
|
Thanks, @boesing; merged to develop for release with 2.4.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we can extract any
DateTimeInterfacerelated object (and therefore future objects), I changed the check toDateTimeInterfaceinstead ofDateTime.Now we can also extract
DateTimeImmutableobjects.Im not quite sure if we want to mix input and output of
StrategyInterface::extractandStrategyInterface::hydrate.Another way would be to provide a
DateTimeImmutableFormatterStrategy.I'm open for better ideas.