This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Prepare develop branch to target PHP 7.2 #80
Merged
Ocramius
merged 35 commits into
zendframework:develop
from
weierophinney:feature/php-7.1-support
Nov 29, 2018
Merged
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b3a3de7
Update dependencies
weierophinney 7b6d85e
Add typehints wherever possible
weierophinney 583cd24
Incorporate changes requested by @vaclavvanik
weierophinney 722b1e4
Update mkdocs.yml
weierophinney 0d07c0d
Adds phpstan into CI toolchain
weierophinney 554d32d
Fix errors reported by phpstan
weierophinney 553d40b
Versions documentation
weierophinney 8ab8be9
Set explicit `object` param/return types in event implementations
weierophinney 042ce54
Use `object` return type for `HydratorListener::onHydrate()`
weierophinney fbcbebf
Adds migration document for v3
weierophinney 6334c28
Revert rename of `pages` to `nav` in `mkdocs.yml`
weierophinney e8cc238
Fix errors flagged by phpstan
weierophinney c867dc0
Use a dist file for phpstan
weierophinney 60f8dc4
Do not iterate if value is null
weierophinney 28d63e7
Use method_exists + is_callable
weierophinney a1225fd
Document all iterable and array parameters, return values, and proper…
weierophinney b81c4ac
Remove unnecessary whitespace in AggregateHydrator
weierophinney 65a93dc
Use the IdentityNamingStrategy as a default naming strategy if none i…
weierophinney 085c710
Import all global functions
weierophinney e3fafb1
Provide documentation for the HydratorPluginManagerFactory
weierophinney 03c7599
Removes unused import in StrategyChain
weierophinney 87d074b
Note that the `$hydrator` property is nullable in HydratorAwareTrait
weierophinney 5e85841
Final CS pass
weierophinney deeaeef
Use PHP 7.3, not nightly, in test matrix
weierophinney 4850813
Remove unnecessary ternary when setting `$explodeLimit`
weierophinney b6115d7
DomainException already implements ExceptionInterface
weierophinney 800dc12
Remove unnecessary property declarations in HydratingArrayIterator
weierophinney 7f62d77
Use null coalesce instead of ternary within ArrayMapNamingStrategy
weierophinney 125194c
Use null coalesce within CompositeNamingStrategy instead of ternary
weierophinney 33e18e1
Remove third argument to `substr` within UnderscoreToCamelCaseFilter
weierophinney b0babc4
Incorporate feedback from @webimpress
weierophinney 046a2ea
Correct typehint for NamingStrategyInterface::extract `$object` argument
weierophinney 1f2e3f7
Updates license docblocks for all test classes and assets
weierophinney e48e508
Remove `lcfirst` import in UnderscoreToCamelCaseFilter
weierophinney b7b5b9a
Sorting of imports when get_class/gettype are used
weierophinney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mb_* functions are used (at least in UnderscoreNamingStrategy\CamelCaseToUnderscoreFilter.php)
Imo we should require ext-mbstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vaclavvanik
Please create a pull request and use the
develop
branch for your improvement. This PR is merged and finished.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i create it tomorrow. today i am sick :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test to see if those functions are available before using them, defaulting to the non-mb variants if they are not. As such, there is no hard requirement on ext-mbstring.