This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add the suffix "Hydrator" to all hydrators #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change is made everywhere, including the `HydratorPluginManager`. That class keeps the old aliases for `ArraySerializable`, but has them point to the `ArraySerializableHydrator` service; it also adds new aliases for the new hydrator name.
Change is made everywhere, including the `HydratorPluginManager`. That class keeps the old aliases for `ClassMethods`, but has them point to the `ClassMethodsHydrator` service; it also adds new aliases for the new hydrator name.
Change is made everywhere, including the `HydratorPluginManager`. That class keeps the old aliases for `ObjectProperty`, but has them point to the `ObjectPropertyHydrator` service; it also adds new aliases for the new hydrator name.
Change is made everywhere, including the `HydratorPluginManager`. That class keeps the old aliases for `Reflection`, but has them point to the `ReflectionHydrator` service; it also adds new aliases for the new hydrator name.
This patch re-adds the following classes as deprecated extensions of the new hydrators: - `ArraySerializable` (extends `ArraySerializableHydrator`) - `ClassMethods` (extends `ClassMethodsHydrator`) - `ObjectProperty` (extends `ObjectPropertyHydrator`) - `Reflection` (extends `ReflectionHydrator`) The `HydratorPluginManager` has been updated to alias these class names to the canonical version.
Also adds a section to the migration document detailing impact.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already used the suffix convention with all filters, strategies, and naming strategies, and even used it with the
DelegatingHydratorandAggregateHydrator. As such, not using suffixes is inconsistent internally.Additionally, it helps prevent ambiguity when importing the classes, particularly with the
Reflectionhydrator (asReflectionis an existing PHP internal class name).This patch makes the following renames:
ArraySerializablebecomesArraySerializableHydratorClassMethodsbecomesClassMethodsHydratorObjectPropertybecomesObjectPropertyHydratorReflectionbecomesReflectionHydratorIn each case, the original class has been re-added to the repository as a deprecated extension, to be removed in version 4.0.0; this was done to make migration easier for end-users.
Additionally, aliases under the original class name were added to the
HydratorPluginManager, pointing to the equivalent service under the new class name, allowing retrieval by either FQCN or short name, and resolving to the correct class.