Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

marshalBadControllerEvent argument type hinting #161

Merged
merged 1 commit into from
Jun 30, 2016
Merged

marshalBadControllerEvent argument type hinting #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DispatchListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ protected function marshalBadControllerEvent(
$controllerName,
MvcEvent $event,
Application $application,
\Exception $exception
\Throwable $exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not gonna work on php 5.6 :(
please have a look in composer.json, and it still must work on: "php": "^5.6 || ^7.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webimpress It works fine on PHP 5.6; the class does not need to exist for a typehint check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that this was in the method signature and not the docblock. I'll remove the typehint during merge.

) {
$event->setName(MvcEvent::EVENT_DISPATCH_ERROR);
$event->setError($application::ERROR_EXCEPTION);
Expand Down