Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Move unnecessary processBodyContent() #184

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

davidwindell
Copy link
Contributor

This is wasting resource for delete's where this doesn't need to be processed

This is wasting resource for delete's where this doesn't need to be processed
@weierophinney weierophinney added this to the 3.0.3 milestone Aug 29, 2016
@weierophinney weierophinney self-assigned this Aug 29, 2016
@weierophinney weierophinney merged commit caf7a59 into zendframework:master Aug 29, 2016
weierophinney added a commit that referenced this pull request Aug 29, 2016
Move unnecessary processBodyContent()
weierophinney added a commit that referenced this pull request Aug 29, 2016
weierophinney added a commit that referenced this pull request Aug 29, 2016
weierophinney added a commit that referenced this pull request Aug 29, 2016
@weierophinney
Copy link
Member

Thanks, @davidwindell!

@trburgess
Copy link

trburgess commented May 8, 2017

@davidwindell @weierophinney

I know this is an old PR, I am just migrating our app to PHP7 and currently using ZF2 2.5.3. This breaks the whole app as when deleting a single resource there is never going to be a body present.

Is it possible to have this back ported to 2.5.*? This shouldn't break anything as $data is not passed as an argument to $this->delete() and therefore is not used at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants