Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix: allow middleware dispatch to behave like controller dispatch #236

Merged
merged 29 commits into from
May 1, 2017
Merged

Fix: allow middleware dispatch to behave like controller dispatch #236

merged 29 commits into from
May 1, 2017

Commits on May 1, 2017

  1. MiddlewareListener should cancel any previous dispatch errors set i… 

    …n the given `MvcEvent`
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    c27997f View commit details
    Browse the repository at this point in the history

  2. Removing route match mock - not needed

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    5a914bd View commit details
    Browse the repository at this point in the history

  3. Canceling previous MvcEvent errors when successfully dispatching a … 

    …middleware
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    ecab36d View commit details
    Browse the repository at this point in the history

  4. Correcting assertion, since MvcEvent#getError() is always a string

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    cb4d7ee View commit details
    Browse the repository at this point in the history

  5. Verifying that the MiddlewareListener will relay anything the middl… 

    …eware produces, regardless of its shape/type, unless it is a PSR7-response
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    0af1831 View commit details
    Browse the repository at this point in the history

  6. Using a real service manager in the MiddlewareListenerTest - no tes… 

    …t is mocking anything particular at this point
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    606ce94 View commit details
    Browse the repository at this point in the history

  7. Removed traditional var_dump() statement

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    1ab5b13 View commit details
    Browse the repository at this point in the history

  8. Creating an intermediate MiddlewareController that makes any middle… 

    …ware act like a normal controller
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    71066ad View commit details
    Browse the repository at this point in the history

  9. Using the MiddlewareListener within the context of a zend-mvc dis… 

    …patch
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    a6d23ff View commit details
    Browse the repository at this point in the history

  10. A shared listener should be attached to middleware, so that the entir… 

    …e useless view layer can do its terrible view model magic
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    3c3136a View commit details
    Browse the repository at this point in the history

  11. Added missing docblock for a test class property

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    a46ae7e View commit details
    Browse the repository at this point in the history

  12. The MiddlewareListener should bail out if an MVC result is already … 

    …present in the dispatched event
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    a37be06 View commit details
    Browse the repository at this point in the history

  13. Skipping dispatch if an MvcEvent#getResult() is not null (fixes tests)

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    0ce89d1 View commit details
    Browse the repository at this point in the history

  14. Verifying that the MiddlewareListener triggers no error events on s… 

    …kipped dispatch
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    533a489 View commit details
    Browse the repository at this point in the history

  15. The dispatch listener should not interfere when `MvcEvent#getResult()… 

    …` already yields a non-null result
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    e78b531 View commit details
    Browse the repository at this point in the history

  16. Skipping dispatch when a non-null MvcEvent#getResult() is detected

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    2d2f887 View commit details
    Browse the repository at this point in the history

  17. Corrected rebase conflicts - moved middleware pipe dispatch into the … 

    …controller wrapper
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    396a650 View commit details
    Browse the repository at this point in the history

  18. Optimised imports

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    50ec228 View commit details
    Browse the repository at this point in the history

  19. Removing unused callable parameters

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    16a77c3 View commit details
    Browse the repository at this point in the history

  20. Splitting request attribute population into a private method

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    e4824a3 View commit details
    Browse the repository at this point in the history

  21. Splitting request checks into their own method

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    7d33ff7 View commit details
    Browse the repository at this point in the history

  22. Removed unused imports

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    6170700 View commit details
    Browse the repository at this point in the history

  23. Removing test that specifies that allowing anything as the return typ… 

    …e of a middleware is OK

This is likely going to land into a separate dispatch listener instead
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    98c6d39 View commit details
    Browse the repository at this point in the history

  24. Documenting the reason for the MiddlewareController to exist

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    8442764 View commit details
    Browse the repository at this point in the history

  25. Basic test coverage for the MiddlewareController

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    29d8e5b View commit details
    Browse the repository at this point in the history

  26. Dispatching a MiddlewareController with an invalid request type sho… 

    …uld raise a `RuntimeException`
    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    145e300 View commit details
    Browse the repository at this point in the history

  27. Removed unused imports

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    4628c44 View commit details
    Browse the repository at this point in the history

  28. Corrected EventManagerInterface type-hint

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    b7f52a9 View commit details
    Browse the repository at this point in the history

  29. CS (whitespace)

    @Ocramius
    Ocramius committed May 1, 2017
    Configuration menu
    Copy the full SHA
    a122791 View commit details
    Browse the repository at this point in the history