Merge pull request #174 from bfolliot/ConfigAbstractFactory_options-f…

…rom-array-object Allows the use of ArrayObject config service with ConfigAbstractFactory
zendframework · Feb 15, 2017 · ba8ea5e · ba8ea5e
2 parents 9247ee5 + 7efae58
commit ba8ea5e
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 2 deletions.
diff --git a/src/AbstractFactory/ConfigAbstractFactory.php b/src/AbstractFactory/ConfigAbstractFactory.php
@@ -7,6 +7,7 @@
 
 namespace Zend\ServiceManager\AbstractFactory;
 
+use ArrayObject;
 use Zend\ServiceManager\Exception\ServiceNotCreatedException;
 use Zend\ServiceManager\Factory\AbstractFactoryInterface;
 
@@ -40,8 +41,8 @@ public function __invoke(\Interop\Container\ContainerInterface $container, $requ
 
         $config = $container->get('config');
 
-        if (! is_array($config)) {
-            throw new ServiceNotCreatedException('Config must be an array');
+        if (! (is_array($config) || $config instanceof ArrayObject)) {
+            throw new ServiceNotCreatedException('Config must be an array or an instance of ArrayObject');
         }
 
         if (! array_key_exists(self::class, $config)) {

diff --git a/test/AbstractFactory/ConfigAbstractFactoryTest.php b/test/AbstractFactory/ConfigAbstractFactoryTest.php
@@ -7,6 +7,7 @@
 
 namespace ZendTest\ServiceManager\AbstractFactory;
 
+use ArrayObject;
 use Zend\ServiceManager\AbstractFactory\ConfigAbstractFactory;
 use Zend\ServiceManager\Exception\ServiceNotCreatedException;
 use Zend\ServiceManager\ServiceManager;
@@ -76,6 +77,39 @@ public function testCanCreate()
         self::assertFalse($abstractFactory->canCreate($serviceManager, ServiceManager::class));
     }
 
+    public function testCanCreateReturnsTrueWhenConfigIsAnArrayObject()
+    {
+        $abstractFactory = new ConfigAbstractFactory();
+        $serviceManager = new ServiceManager();
+        $serviceManager->setService(
+            'config',
+            new ArrayObject([
+                ConfigAbstractFactory::class => [
+                    InvokableObject::class => [],
+                ]
+            ])
+        );
+
+        self::assertTrue($abstractFactory->canCreate($serviceManager, InvokableObject::class));
+        self::assertFalse($abstractFactory->canCreate($serviceManager, ServiceManager::class));
+    }
+
+    public function testFactoryCanCreateInstancesWhenConfigIsAnArrayObject()
+    {
+        $abstractFactory = new ConfigAbstractFactory();
+        $serviceManager = new ServiceManager();
+        $serviceManager->setService(
+            'config',
+            new ArrayObject([
+                ConfigAbstractFactory::class => [
+                    InvokableObject::class => [],
+                ]
+            ])
+        );
+
+        self::assertInstanceOf(InvokableObject::class, $abstractFactory($serviceManager, InvokableObject::class));
+    }
+
     public function testInvokeWithInvokableClass()
     {
         $abstractFactory = new ConfigAbstractFactory();