This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Allow proxymanager v2 installation #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -750,6 +752,10 @@ private function createLazyServiceDelegatorFactory() | |||
|
|
|||
| if (! isset($this->lazyServices['write_proxy_files']) || ! $this->lazyServices['write_proxy_files']) { | |||
| $factoryConfig->setGeneratorStrategy(new EvaluatingGeneratorStrategy()); | |||
There was a problem hiding this comment.
This block becomes superfluous when ProxyManager v1 support is dropped (this is the default behavior now)
Ocramius
force-pushed
the
feature/allow-proxymanager-v2-installation
branch
from
575e9c9 to
ed4d4b1
Compare
|
@weierophinney Any reasons why this PR is not already merged. The lazy_services setting |
|
@Ocramius Patch looks good to me; feel free to merge and tag a release. |
|
Included into 3.1.0 via d27e109 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows installation of ProxyManager v2.*
The changes are not breaking, but ProxyManager v2 has PHP 7 type-hints everywhere, which means that PHPUnit 5.* is required in order to mock them (specifically, PHPUnit 5.2.9+). This patch adds the required changes, as well as the polyfills required to have ProxyManager v2 behave like ProxyManager v1, configuration-wise