This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
PhpRendererStrategy should be able to handle an event w/o a response #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViewEvent#getResponse() may return null, but PhpRendererStrategy#injectResponse() didn't handle that case.
|
I wasn't sure what to test for since I just expect the method not to throw an error. Please let me know if I should change the test. |
|
What should I do about the PHPUnit incompatibility? ( |
|
|
@froschdesign So I shouldn't do anything and the failing builds are OK? |
|
@MidnightDesign I've merged other commits today that upgrade the PHPUnit install; as long as your new test passes, it's fine. |
weierophinney
added a commit
that referenced
this pull request
Mar 20, 2017
…response PhpRendererStrategy should be able to handle an event w/o a response
weierophinney
added a commit
that referenced
this pull request
Mar 20, 2017
weierophinney
added a commit
that referenced
this pull request
Mar 20, 2017
|
Thanks, @MidnightDesign |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewEvent#getResponse() may return null, but PhpRendererStrategy#injectResponse() didn't handle that case.