Deprecate Attribs and Proxy to Attributes #139

wandersonwhcr · 2017-09-15T03:07:53Z

Remove all references to attribs, translating to attributes. Public methods like setAttribs and getAttribs trigger an E_USER_DEPRECATED and proxy to setAttributes and getAttributes instead.

Fix #87

froschdesign · 2017-09-15T05:38:50Z

test/Helper/GravatarTest.php

@@ -302,4 +302,12 @@ public function testSetAttribsDocCommentHasDeprecated()

        $this->assertContains('@deprecated', $comment);
    }
+
+    /**
+     * @expectedException PHPUnit\Framework\Error\Deprecated


Please look at Travis:

ZendTest\View\Helper\GravatarTest::testGetAttribsIsDeprecated
ReflectionException: Class PHPUnit\Framework\Error\Deprecated does not exist

https://travis-ci.org/zendframework/zend-view/jobs/275727410#L733

froschdesign · 2017-09-15T05:39:38Z

test/Helper/GravatarTest.php

@@ -285,4 +285,12 @@ public function testEmailIsProperlyNormalized()
            $this->helper->__invoke('Example@Example.com ')->getEmail()
        );
    }
+
+    /**
+     * @expectedException PHPUnit\Framework\Error\Deprecated


Please look at Travis:

ZendTest\View\Helper\GravatarTest::testSetAttribsIsDeprecated
ReflectionException: Class PHPUnit\Framework\Error\Deprecated does not exist

https://travis-ci.org/zendframework/zend-view/jobs/275727410#L730

Yes. I forgot to comment about it (0:01 AM). I'll fix it right now

I would suggest using method instead of annotation. I know here it doesn't matter because test contain just one call, but I would change it for consistency.

I don't like annotations, too. But, if I remember, this use is recommended. But I'll change it.

froschdesign · 2017-09-15T05:42:46Z

Related to #87

wandersonwhcr · 2017-09-15T13:14:11Z

I'll create test/phpunit-bc.php (backward compatibility) file that maps PHPUnit\Framework\Error\Deprecated to PHPUnit_Framework_Error_Deprecated, only when needed. After that, I'll change composer.json, adding a files attribute with ["test/phpunit-bc.php"] inside autoload-dev entry.

@froschdesign is that OK? :)

wandersonwhcr · 2017-09-16T17:40:09Z

I broke HHVM instances. Let's see what I can do.

michalbundyra · 2017-09-16T17:41:43Z

@wandersonwhcr We are dropping hhvm support anyway...

michalbundyra · 2017-09-16T17:46:16Z

src/Helper/Gravatar.php

+     * @param  array $attributes
+     * @return Gravatar
+     *
+     * @deprecated Please use Zend\View\Helper\Gravatar::setAttributes


We shouldn't have deprecated tag on that method.

michalbundyra · 2017-09-16T17:54:18Z

@wandersonwhcr

I'll create test/phpunit-bc.php

In other libraries we have test/autoload.php, for example have a look here:
https://github.com/zendframework/zend-modulemanager/blob/master/test/autoload.php

wandersonwhcr · 2017-09-16T19:16:19Z

I rebased my branch and changed source as requested. I hate "do-undo-redo" commits ;)

I'll fix HHVM, just give a couple of hours.

wandersonwhcr · 2017-09-17T19:28:38Z

Done.

Deprecate Attribs and Proxy to Attributes

Close #139

weierophinney · 2018-01-17T22:18:56Z

Thanks, @wandersonwhcr. Merged to develop for release with 2.10.0.

froschdesign · 2018-01-17T22:20:56Z

@weierophinney
Is there a reason why you remove all labels after you have closed a PR?

weierophinney · 2018-01-17T23:14:05Z

@froschdesign I... didn't? At least, not intentionally. I have no idea why it indicates that at this point. I don't recall doing anything other than closing the window after I was done with this merge; the comment itself was added via the CLI.

froschdesign suggested changes Sep 15, 2017

View reviewed changes

froschdesign added the bug label Sep 15, 2017

froschdesign added this to the 2.10.0 milestone Sep 15, 2017

michalbundyra reviewed Sep 16, 2017

View reviewed changes

wandersonwhcr added 8 commits September 16, 2017 16:09

Trigger a deprecated error for setAttribs method

3741bfb

Add deprecated DocComment tag for setAttribs

d8086fa

Apply proxy from setAttribs to setAttributes

af4b9fc

Trigger a deprecated error for getAttribs method

9910c88

Add deprecated DocComment tag for getAttribs

c6d8e0c

Apply proxy from getAttribs to getAttributes

0165929

Fix internal nomenclature for attribs

795ea25

Create an autoload script for tests

db6b1c3

wandersonwhcr added 3 commits September 17, 2017 15:27

Alias deprecated errors for PHPUnit lowest dep

d83fad5

Increase execution time for PHPUnit code coverage

2c2cc49

Increase error reporting for PHPUnit with HHVM

7f4d56e

weierophinney added a commit that referenced this pull request Jan 17, 2018

Merge pull request #139 from wandersonwhcr/hotfix/87

7abc52a

Deprecate Attribs and Proxy to Attributes

weierophinney added a commit that referenced this pull request Jan 17, 2018

Adds CHANGELOG entries for #139

2ecf680

weierophinney added a commit that referenced this pull request Jan 17, 2018

Merge branch 'feature/139' into develop

31e1d0b

Close #139

weierophinney closed this Jan 17, 2018

weierophinney removed the bug label Jan 17, 2018

wandersonwhcr deleted the hotfix/87 branch January 18, 2018 10:44

samsonasik mentioned this pull request Apr 6, 2018

Gravatar Helper with Attribs Method #87

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate Attribs and Proxy to Attributes #139

Deprecate Attribs and Proxy to Attributes #139

wandersonwhcr commented Sep 15, 2017 •

edited

Loading

froschdesign Sep 15, 2017

froschdesign Sep 15, 2017

wandersonwhcr Sep 15, 2017

michalbundyra Sep 16, 2017

wandersonwhcr Sep 16, 2017 •

edited

Loading

froschdesign commented Sep 15, 2017

wandersonwhcr commented Sep 15, 2017 •

edited

Loading

wandersonwhcr commented Sep 16, 2017 •

edited

Loading

michalbundyra commented Sep 16, 2017

michalbundyra Sep 16, 2017

wandersonwhcr Sep 16, 2017

michalbundyra commented Sep 16, 2017

wandersonwhcr commented Sep 16, 2017

wandersonwhcr commented Sep 17, 2017

weierophinney commented Jan 17, 2018

froschdesign commented Jan 17, 2018

weierophinney commented Jan 17, 2018

Deprecate Attribs and Proxy to Attributes #139

Deprecate Attribs and Proxy to Attributes #139

Conversation

wandersonwhcr commented Sep 15, 2017 • edited Loading

froschdesign Sep 15, 2017

Choose a reason for hiding this comment

froschdesign Sep 15, 2017

Choose a reason for hiding this comment

wandersonwhcr Sep 15, 2017

Choose a reason for hiding this comment

michalbundyra Sep 16, 2017

Choose a reason for hiding this comment

wandersonwhcr Sep 16, 2017 • edited Loading

Choose a reason for hiding this comment

froschdesign commented Sep 15, 2017

wandersonwhcr commented Sep 15, 2017 • edited Loading

wandersonwhcr commented Sep 16, 2017 • edited Loading

michalbundyra commented Sep 16, 2017

michalbundyra Sep 16, 2017

Choose a reason for hiding this comment

wandersonwhcr Sep 16, 2017

Choose a reason for hiding this comment

michalbundyra commented Sep 16, 2017

wandersonwhcr commented Sep 16, 2017

wandersonwhcr commented Sep 17, 2017

weierophinney commented Jan 17, 2018

froschdesign commented Jan 17, 2018

weierophinney commented Jan 17, 2018

wandersonwhcr commented Sep 15, 2017 •

edited

Loading

wandersonwhcr Sep 16, 2017 •

edited

Loading

wandersonwhcr commented Sep 15, 2017 •

edited

Loading

wandersonwhcr commented Sep 16, 2017 •

edited

Loading