-
Notifications
You must be signed in to change notification settings - Fork 61
Avoid needless Zend\Filter dependency #25
Avoid needless Zend\Filter dependency #25
Conversation
👍 |
Hi @danizord , Can I understand what the filter chain exactly is doing ? My feelings are in this direction for I fear magic behind this. I am sure people will come blame if they expect something from the Filter .
EDIT : Though I don't like it very much, but still this helps people I guess, and can also make a note about can extend the Filter with some interface ?
So I am not in favour of this PR for I don't know the drawbacks if the filter is not calling. |
No drawbacks. When an instance of Previously it was creating an empty |
ok cool. Thanks for the information @danizord . So what is the real purpose of keeping the unused |
Mainly for backwards compatibility. But even if it is not widely used, it is still useful if you want to filter output |
Pinging @weierophinney for review :) |
Avoid needless Zend\Filter dependency
As far I know the filter chain of
PhpRenderer
is not used byZend\Mvc
default rendering strategy (@weierophinney can you confirm?) and it seems like most users ofPhpRenderer
does not use the filter chain feature at all.So I added this check to avoid
Zend\Filter
dependency when the filter chain is not explicity defined bysetFilterChain()
nor lazy initialized bygetFilterChain()
.Maybe that fixes #3, #12 and #24.