-
Notifications
You must be signed in to change notification settings - Fork 61
Ensure Navigation helper PluginManager is BC #47
Ensure Navigation helper PluginManager is BC #47
Conversation
Adds tests similar to those for the `HelperPluginManager` to ensure that the first argument to the `Navigation\PluginManager` is optional and/or accepts a `Zend\ServiceManager\Config` instance, and updates the constructor to work with both v2 and v3.
Implements a full compatibility test for the navigation plugin manager.
Most recent changes also address the alias resolution reported in #46. |
In a private email, @webimpress has indicated that the initializers registered by |
Okay, what I've discovered is that Under v2, this worked because of this line:
which essentially made it so that the navigation plugins, even if translator-aware, are never injected with a translator. I'll re-instate that behavior for now, and later, when preparing zend-navigation for forwards-compatibility, I'll set it up to create a navigation plugin manager that's injected with the parent locator of the helper plugin manager. |
Adds a test for a condition reported by @webimpress, detailing expected behavior if the plugin manager does not have a parent locator when `injectTranslator()` is called (should return null, not error), and adds a conditional into `injectTranslator()` to return early if no container is available.
... when testing against zend-servicemanager v3.
Close #47 Fixes #46 Fixes #45 Fixes zendframework/zend-navigation#19
Looks good! |
Good 👍 2.6.2 works fine for me.. Thanks |
Adds tests similar to those for the
HelperPluginManager
to ensure that the first argument to theNavigation\PluginManager
is optional and/or accepts aZend\ServiceManager\Config
instance, and updates the constructor to work with both v2 and v3.Fixes zendframework/zend-navigation#19 and zenframework/zend-view#45