Asset helper

[michalbundyra]

Asset view helper. It required resource map (array) configuration. Can be used also with JSON file (eg. generated by gulp/grunt - rev-manifest.json) as described in docs.

I am not 100% happy with tests because of confusing compatibility with zend-servicemanager v2 and v3.

Any suggestions would be appreciated.

[weierophinney]

This looks like a nice solution in terms of being light-weight, and integrating with established front-end workflows.

My one comment: I wonder if this should integrate with basePath()? As an example, once the path is resolved from the resource map, should that path then be passed to basePath() in order to ensure it is resolved correctly? My inclination is yes, but the question is if the helper should do that internally, or if we should document that the workflow should be:

<?= $this->basePath($this->asset('css/style.css')) ?>

In particular, the use of relative URLs in the resource map may be problematic when on a path that represents more than one level deep in the tree (e.g., '/foo/bar/baz' would make 'css/style.css' resolve to '/foo/bar/css/style.css' on most browsers). If the asset paths are expected to be relative to the application root, we need to either enforce that within the helper, or document that the developer is responsible for this.

Thoughts?

[michalbundyra]

@weierophinney good point. I thought about it, and I think developer should be responsible to ensure he has a good paths. We can add into documentation example with basePath helper, everything depends on resource map array - if there are relative or absolute paths.

I think better if we allow decide developers how they want use it. Probably it will be used mostly with plugins headLink, headScript, ... I can imagine also that maybe somebody will use it as following:

'view_helper_config' => [
    'asset' => [
        'resource_map' => [
            'jquery' => 'https://code.jquery.com/jquery-3.0.0.min.js',
        ],
    ],
],

and in view:

<?= $this->headScript()->appendFile($this->asset('jquery')) ?>

It's hard to say how it will be used, but I think without integration with basePath we have a greater capacity of use.

BTW. How you'd like to use one plugin inside another? Pass it via factory?

[froschdesign]

Please put the note in a blockqoute.

> ### Note
> ...

[froschdesign]

Add a full DocBlock. (description, parameter, return value)

[froschdesign]

Same here.

[froschdesign]

Please add the helper in the DocBlock of PhpRenderer for code completion in IDEs.

[michalbundyra]

Done 3e08baf

[michalbundyra]

@froschdesign I've made all requested changes and added also a few fixes

[weierophinney]

Thanks, @webimpress