Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Feature for passing parameters into navigation-partial. #8

Conversation

Zyqsempai
Copy link

Finished feature for passing parameters into navigation helper partial view model. new branch with @weierophinney 's idea realization.

@Zyqsempai
Copy link
Author

I think that we can close this one #7 , to mach conflicts on that branch.

@Martin-P
Copy link
Contributor

Can you please undo all cosmetic changes, like:

  • ending comments with a dot .
  • removal of spaces when concatenating strings
  • removal of empty lines
  • adding empty lines before @return annotations
  • etc.

The correct coding standard is the way @weierophinney wrote it: weierophinney@8091297

@Zyqsempai
Copy link
Author

I skipped my code through php-cs-fixer and i thought that it will fix all those cosmetic issues.

@Maks3w
Copy link
Member

Maks3w commented Jul 22, 2015

Did you execute php-cs-fixer with the provided .php_cs file?

As @mwillbanks said please undo all that stuff

@weierophinney
Copy link
Member

Merged to develop for release with 2.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants