-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up publishing to Entrepot #22
base: master
Are you sure you want to change the base?
Conversation
edf0377
to
dd31821
Compare
Looks like we have a "random" error in a test... I had a test failure in
I'll try to see if I can find something... |
Looks like the above error is caused by a thread-safety issue in Accolyte ; I can reproduce the error semi-randomly when I execute the tests as-is, but I can no longer reproduce it if I synchronize the test database creation ( |
dd31821
to
b33a113
Compare
I'm surprise, Acolyte used fully isolated connection, I'm would rather check the connection handler it's given, as that could be concurrent in tests (and if there is mutations there ...) |
b33a113
to
bb08320
Compare
bb08320
to
359cc3f
Compare
I'd like to finally finish those old PRs... I think this one should be good to merge if there are no more problems with it ? @stankoua @cchantep (The random test failure is fixed by cchantep/acolyte#93 but we'll need a new release of Acolyte to benefit from it. Anyway, not specific to this PR.) |
Pull Request Checklist
Purpose
Set up publishing to Entrepot
Background Context
N/A
References
Depends on pull request #19