Cats io support #26
Open
Cats io support #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stankoua
force-pushed
the
task/cats-io-support
branch
from
01466f3
to
b6b7f4e
Compare
cchantep
reviewed
Feb 9, 2019
| /** | ||
| * Heavily inspired from work done by @cchantep in Acolyte (see acolyte.reactivemongo.ComposeWithCompletion) | ||
| */ | ||
| trait LiftAsync[F[_], M[_], A] { |
There was a problem hiding this comment.
Semantic is always async ?
There was a problem hiding this comment.
yes (but no in term of cats-effect's Async typeclass), since the essence of this typeclass is to wrap the computation in an async context (Future or IO). Maybe it can be confusing, so feel free to suggest any name which could express it better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Purpose
Currently we are supporting the translation of our DB operations to
Future.Futureis actually eager so the DB operations will be executed during the translations process. It might be useful to add support for a lazy asynchronous datatype. We choose to add support for theIOtype provided bycats-effect.Why choosing
cats-effector notzio?cats-effectcome with typeclasses which formalize operations (think ofAsync,Sync).For people using
zio, they will have to use a bridge project between the two.