Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a keyword to set cursor position in minibuffer. #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PierreTechoueyres
Copy link
Contributor

  • smart-compile.el (smart-compile-string): rewrite token replacement
    and return a cons of string and position.

@zenitani
Copy link
Owner

Thank you very much for your proposal. Let me have some more time to understand this. So far, it doesn't appear to be compatible with my emacsen (ver. 22 and 24).

@PierreTechoueyres
Copy link
Contributor Author

I did not know (or I was not careful) that you still support this version of Emacs.
Then I understand that none of my public relations will apply properly.
Emacs 22 is really old and I'm not sure that the PR for the local file variable could be easily added.
For the other, it's the essentially sugar syntax that can be rewritten with the loop and the if construct.
I will try to send you another version except if you found the solution before.

@PierreTechoueyres PierreTechoueyres force-pushed the pte/cursor-position branch 2 times, most recently from fe7b467 to 6b2b07d Compare December 31, 2023 17:48
* smart-compile.el (smart-compile-string): rewrite token replacement
  and return a cons of string and position.
Fix typo in my name.
@PierreTechoueyres
Copy link
Contributor Author

Would you mind revisit this PR ?

@zenitani
Copy link
Owner

zenitani commented Jan 2, 2024

I have updated the code. Thank you for your contribution.
I will close this ticket in two or three weeks, unless I will hear any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants