Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Disable Python 3.7 Mac Runners #1650

Merged
merged 3 commits into from
Jun 27, 2023
Merged

CI: Disable Python 3.7 Mac Runners #1650

merged 3 commits into from
Jun 27, 2023

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented Jun 26, 2023 •
edited
Loading

Describe changes

Disabling Mac runners under Python 3.7 since they are currently broken: actions/setup-python#682

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Jun 26, 2023
schustmi
schustmi approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a ticket for next sprint to check if we can reenable them so we don't forget?

stefannica
stefannica approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@stefannica stefannica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove all python 3.7 jobs ? It will be EOL tomorrow anyway.

@fa9r
Copy link
Contributor Author

fa9r commented Jun 26, 2023

@stefannica love it! 😄

@schustmi WDYT?

@fa9r fa9r requested review from schustmi and stefannica June 26, 2023 11:37
@fa9r fa9r changed the title CI: Disable Mac Runners for Python 3.7 CI: Disable Python 3.7 Runners Jun 26, 2023
@fa9r fa9r changed the title CI: Disable Python 3.7 Runners CI: Python 3.7 Mac Runners Jun 26, 2023
@fa9r fa9r merged commit a91dbf7 into develop Jun 27, 2023
@fa9r fa9r deleted the misc/disable-mac-37-ci-checks branch June 27, 2023 08:46
@fa9r fa9r mentioned this pull request Jun 27, 2023
Merged
8 tasks
@fa9r fa9r changed the title CI: Python 3.7 Mac Runners CI: Disable Python 3.7 Mac Runners Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexejPenner AlexejPenner Awaiting requested review from AlexejPenner

@schustmi schustmi Awaiting requested review from schustmi

@stefannica stefannica Awaiting requested review from stefannica

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fa9r @stefannica @schustmi