fix: create ArrayCollection if needed #645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review #653 before, as this PR is built is the top of the other
fixes #474
this is a really naive approach, nonetheless, this could be helpful.
It will only work if the property is actually type hinted with
Doctrine\Common\Collections\Collection
.It won't create an
ArrayCollection
if the property is only type hinted with phpdoc, or if it has a complex type hint (for instance, I saw in few occasions something likeprivate array|Collection $relations
).Another cleaner approach would have been to use doctrine metadata in
Hydrator
but this seemed convoluted.But I think the current implementation is good enough for now, since the type hint with
Collection
is how it is documented by Doctrine.Maybe in the future we might support other
\Traversable
objects?