fix: make proxy work with last symfony/var-exporter version #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/proxy-unserializer
branch
2 times, most recently
from
284fb67
to
3c50418
Compare
nikophil
force-pushed
the
fix/proxy-unserializer
branch
from
3c50418
to
70af42b
Compare
kbond
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oups... this "unserialize" stuff introduced here does not work with the last version of
symfony/var-exporter, because of a semicolon 😅since symfony has released my fix I've removed the "monkey patch" and bumped the var exporter version
We should make a release after merging this PR