Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hasher from std to fxhasher #25

Open
zeon256 opened this issue Feb 13, 2022 · 4 comments
Open

Change hasher from std to fxhasher #25

zeon256 opened this issue Feb 13, 2022 · 4 comments

Comments

@zeon256
Copy link
Owner

zeon256 commented Feb 13, 2022

No description provided.

@zeon256
Copy link
Owner Author

zeon256 commented Jun 7, 2022

Decided to change hasher from std to AHash instead of fxhasher, no idea about perf, havent tested

@zeon256
Copy link
Owner Author

zeon256 commented Jun 8, 2022

Seems like there is some perf reduction on master, cant pin point what exactly is causing the perf degradation, but I am suspecting the use of Ahash is affecting it

❯ wrk -c100 -d15s -t8 http://localhost:8080/api/v1/timings/83139                                                          ─╯
Running 15s test @ http://localhost:8080/api/v1/timings/83139
  8 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   474.88us    4.92ms 124.97ms   99.38%
    Req/Sec    87.78k     6.31k  111.67k    94.02%
  10532028 requests in 15.10s, 15.62GB read
  Non-2xx or 3xx responses: 56
Requests/sec: 697471.72
Transfer/sec:      1.03GB

@zeon256
Copy link
Owner Author

zeon256 commented Jun 8, 2022

Regarding this issue, I think we should just parameterize the hashmaps rather than using the different hasher

zeon256 added a commit that referenced this issue Jun 8, 2022
@zeon256
Copy link
Owner Author

zeon256 commented Jun 19, 2022

Using Fxhash is causing this problem

Requested application data is not configured correctly. View/enable debug logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant