Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass any Go pointers into C #1

Open
davidben opened this issue Feb 4, 2015 · 1 comment
Open

Don't pass any Go pointers into C #1

davidben opened this issue Feb 4, 2015 · 1 comment

Comments

@davidben
Copy link
Contributor

davidben commented Feb 4, 2015

Judging from http://golang.org/issue/8310 and https://groups.google.com/d/msg/golang-nuts/Is60OjYF5I4/t7QaeZJ5XLcJ, it's not clear bytesToKrb5Data and friends are safe / will stay safe. Sort out what's going on here; maybe we need to malloc stuff, which would be mildly annoying.
@davidben
Copy link
Contributor Author

davidben commented Feb 3, 2016

Sounds like the rules are set now. We should check that we comply now.

davidben added a commit that referenced this issue Jul 4, 2017
@davidben
Fix some cgo pointer violations.
c30f33b 
This still doesn't work, but the test suite gets further along now. Some of the
simpler structures can save a malloc by exploding the structs into parameters.

Issue #1.
davidben added a commit that referenced this issue Jul 4, 2017
@davidben
Pass structs by value rather than exploding.
5052743 
This is probably a cleaner way to handle issue #1.
davidben added a commit that referenced this issue Jul 4, 2017
@davidben
Satisfy cgo pointer rules for keytab bits.
b47f41c 
Issue #1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidben