Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrfx: hal: Add accessor functions for FICR addr, er and ir #196

Closed
wants to merge 1 commit into from
Closed

nrfx: hal: Add accessor functions for FICR addr, er and ir #196

wants to merge 1 commit into from

Conversation

carlescufi
Copy link
Member

Abstract the access to three BLE-related settings in FICR for different nRF SoCs, so the user does not need to worry about differences among series.

@carlescufi
Copy link
Member Author

Will soon add the zephyr main tree PR

anangl
anangl approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@anangl anangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit: the commit title should start with "nrfx: hal:" instead of just "hal:".

@carlescufi
nrfx: hal: Add accessor functions for FICR addr, er and ir
69752bf 
Abstract the access to three BLE-related settings in FICR for different
nRF SoCs, so the user does not need to worry about differences among
series.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi
Copy link
Member Author

Just one nit: the commit title should start with "nrfx: hal:" instead of just "hal:".

Thanks, fixed.

@carlescufi carlescufi changed the title hal: Add accessor functions for FICR addr, er and ir nrfx: hal: Add accessor functions for FICR addr, er and ir Jul 5, 2024
@carlescufi carlescufi mentioned this pull request Jul 5, 2024
Merged
carlescufi added a commit to carlescufi/zephyr that referenced this pull request Jul 5, 2024
@carlescufi
drivers: hwinfo: Add support for generating device id from device addr
e0a010d 
In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi added a commit to carlescufi/zephyr that referenced this pull request Jul 8, 2024
@carlescufi
drivers: hwinfo: Add support for generating device id from device addr
39fa6c9 
In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi
Copy link
Member Author

superseeded by #200

@carlescufi carlescufi closed this Aug 1, 2024
carlescufi added a commit to carlescufi/zephyr that referenced this pull request Aug 1, 2024
@carlescufi
drivers: hwinfo: Add support for generating device id from device addr
5ee9c98 
In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
fabiobaltieri pushed a commit to zephyrproject-rtos/zephyr that referenced this pull request Aug 2, 2024
@carlescufi @fabiobaltieri
drivers: hwinfo: Add support for generating device id from device addr
ebd31d3 
In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Aug 3, 2024
@carlescufi
drivers: hwinfo: Add support for generating device id from device addr
28b6400 
In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

(cherry picked from commit ebd31d3)

Original-Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
GitOrigin-RevId: ebd31d3
Cr-Build-Id: 8740696253239544497
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8740696253239544497
Change-Id: I017bd5007759b76a970cb9bd3751297321adaabd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5760303
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
kapi-no pushed a commit to kapi-no/sdk-zephyr that referenced this pull request Aug 30, 2024
@carlescufi @kapi-no
[nrf fromtree] drivers: hwinfo: Add support for generating device id …
7dd6674 
…from device addr

In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
(cherry picked from commit ebd31d3)
carlescufi added a commit to nrfconnect/sdk-zephyr that referenced this pull request Aug 30, 2024
@carlescufi
[nrf fromtree] drivers: hwinfo: Add support for generating device id …
425e40b 
…from device addr

In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
(cherry picked from commit ebd31d3)
mariucker pushed a commit to mariucker/zephyr that referenced this pull request Dec 12, 2024
@carlescufi @mariucker
drivers: hwinfo: Add support for generating device id from device addr
6163d2b 
In some ICs (including nRF54H20) the DEVICEID register is not part of
FICR, and thus it is not accessible to applications. Use instead the
device address, along with a couple of bytes from ER and IR, to
generated a unique device id.

At the same time update the pointer to the hal_nordic repo to pull in
zephyrproject-rtos/hal_nordic#196.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarull gmarull gmarull left review comments

@masz-nordic masz-nordic masz-nordic approved these changes

@anangl anangl anangl approved these changes

@nika-nordic nika-nordic Awaiting requested review from nika-nordic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlescufi @anangl @gmarull @masz-nordic