Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot: zephyr: Fix build issue for multiple conf files #32

Merged

Conversation

nvlsianpu
Copy link
Collaborator

Change fixes build issue that occurs if CONF_FILE contains multiple
file paths instead of single file path.

Signed-off-by: Marek Pieta Marek.Pieta@nordicsemi.no
Signed-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no

Change fixes build issue that occurs if CONF_FILE contains multiple
file paths instead of single file path.

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
@nvlsianpu nvlsianpu requested a review from utzig September 10, 2020 09:52
@nvlsianpu
Copy link
Collaborator Author

cc @MarekPieta

@nvlsianpu
Copy link
Collaborator Author

nvlsianpu commented Sep 10, 2020

miror PR of mcu-tools#795 (merged)

Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

I do not know whether it is possible to be done with CMake but maybe in the future this could be improved to check whether all key definitions point to the same key, because if they all point to the same this is not an issue.

@nvlsianpu nvlsianpu merged commit a5d79cf into zephyrproject-rtos:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants