Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.7.0-4826-g372b3a9b8da2: stm32 results #1887

Merged

Conversation

erwango
Copy link
Member

@erwango erwango commented Oct 23, 2024

Non reg result analysis on last run:

Failed tests:
(verdicts: T/p: Passed, F/f: Failed, t:timeout)
samples/drivers/led/pwm/sample.drivers.led.led_pwm, disco_l475_iot1
samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_c031c6
samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_f091rc
samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_f207zg
samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_g474re
samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_h743zi
samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_l073rz
samples/drivers/watchdog/sample.drivers.watchdog.stm32h7_wwdg, nucleo_h743zi
samples/modules/cmsis_dsp/moving_average/sample.modules.cmsis_dsp.moving_average, nucleo_f091rc (instable: pppffpfppfpppppppppppppppppppppppppp)
samples/psa/its/sample.psa.its.secure_storage.entropy_driver, nucleo_f207zg
samples/psa/its/sample.psa.its.secure_storage.entropy_driver, nucleo_f429zi
samples/psa/its/sample.psa.its.secure_storage.entropy_driver, nucleo_h743zi
samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_f207zg
samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_f429zi
samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_g071rb
samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_h743zi
samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_l152re
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_driver, nucleo_f207zg
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_driver, nucleo_f429zi
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_driver, nucleo_h743zi
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_f207zg
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_f429zi
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_g071rb
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_h743zi
samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_l152re
samples/sensor/accel_trig/sample.sensor.accel_trig, stm32f3_disco
samples/sensor/magn_trig/sample.sensor.magn_trigger, stm32f3_disco
samples/subsys/nvs/sample.nvs.basic, disco_l475_iot1
samples/subsys/nvs/sample.nvs.basic, nucleo_g474re
samples/subsys/nvs/sample.nvs.basic, nucleo_l152re
samples/subsys/nvs/sample.nvs.basic, nucleo_wb55rg
samples/subsys/nvs/sample.nvs.basic, nucleo_wl55jc
samples/subsys/nvs/sample.nvs.basic, stm32f3_disco
samples/subsys/portability/cmsis_rtos_v1/timer_synchronization/sample.portability.cmsis_rtos_v1.timer_synchronization, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
samples/subsys/portability/cmsis_rtos_v2/timer_synchronization/sample.portability.cmsis_rtos_v2.timer_synchronization, stm32h7s78_dk (instable: pppfppfppfpppp)
tests/benchmarks/wait_queues/benchmark.wait_queues.dumb, stm32h7s78_dk (instable: pppfpp)
tests/drivers/clock_control/stm32_clock_configuration/stm32_common_core/drivers.clock.stm32_clock_configuration.common_core.f0_f3.sysclksrc_hsi_8, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
tests/drivers/clock_control/stm32_clock_configuration/stm32_common_core/drivers.clock.stm32_clock_configuration.common_core.f0_f3.sysclksrc_pll_32_hsi_8, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
tests/drivers/clock_control/stm32_clock_configuration/stm32_common_devices/drivers.clock.stm32_clock_configuration.common_device.g0.i2c1_sysclk_lptim1_lsi, nucleo_g071rb
tests/drivers/dma/chan_blen_transfer/drivers.dma.chan_blen_transfer.low_footprint, nucleo_c031c6
tests/drivers/flash/common/drivers.flash.common.default, nucleo_f207zg
tests/drivers/flash/common/drivers.flash.common.default, nucleo_g071rb
tests/drivers/flash/common/drivers.flash.common.default, nucleo_l152re
tests/drivers/flash/common/drivers.flash.common.stm32, nucleo_f207zg
tests/drivers/flash/common/drivers.flash.common.stm32, nucleo_l152re
tests/drivers/ipm/drivers.ipc.mailbox, nucleo_f746zg (instable: pppfppfppfppfppppppppppppppppppppppp)
tests/drivers/spi/dt_spec/drivers.spi.dt_spec, nucleo_f091rc (instable: pppfpffppfpppppppppppppppppppppppppp)
tests/drivers/uart/uart_async_api/drivers.uart.async_api, nucleo_c031c6
tests/kernel/context/kernel.context.minimallibc, stm32h7s78_dk
tests/kernel/mem_heap/k_heap_api/kernel.k_heap_api, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
tests/kernel/pending/kernel.objects, nucleo_f091rc
tests/kernel/timer/timepoints/kernel.timer.timepoints, stm32h7s78_dk (instable: pppfppfppfpppp)
tests/lib/c_lib/common/libraries.libc.common, nucleo_f091rc
tests/lib/c_lib/common/libraries.libc.common.picolibc, nucleo_f091rc
tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cf32.fpu, nucleo_h743zi
tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cf64, nucleo_h743zi
tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cf64.fpu, nucleo_h743zi
tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.rf64, nucleo_h743zi
tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.rf64.fpu, nucleo_h743zi
tests/lib/spsc_pbuf/libraries.spsc_pbuf.utilization, nucleo_f103rb
tests/net/dhcpv6/net.dhcpv6, nucleo_f429zi (instable: pppfppfppfpppppppppppppppppppppppppp)
tests/net/lib/prometheus/formatter/prometheus.formatter, nucleo_f429zi
tests/net/lib/prometheus/formatter/prometheus.formatter, stm32h573i_dk
tests/subsys/ipc/pbuf/ipc.icmsg_pbuf, nucleo_f091rc
tests/subsys/logging/log_frontend_stmesp_demux/debug.coresight.stp_demux_max_utilization, stm32h7s78_dk (instable: pppffpfppfpppp)
tests/subsys/logging/log_immediate/logging.immediate.clean_output, nucleo_f091rc
tests/subsys/logging/log_output/logging.output, nucleo_f091rc
tests/subsys/logging/log_output/logging.output.thread_id, nucleo_f091rc (instable: pppffpfppfpppp)
tests/subsys/rtio/workq/rtio.workq, nucleo_f091rc (instable: pfpfppfppfpppppppppppppppppppppppppppp)
tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_f207zg
tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_f429zi
tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_g071rb
tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_h743zi
tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_l152re
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, disco_l475_iot1
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_f103rb (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_f207zg
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_f429zi
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_g071rb
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_g474re (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_h743zi
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_l152re
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_wb55rg
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_wba55cg
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_wl55jc (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, stm32h573i_dk (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, disco_l475_iot1
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f091rc
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f103rb (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f207zg
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f429zi
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_g071rb
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_g474re (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_h743zi
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_l152re
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_wb55rg
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_wba55cg
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_wl55jc (instable: pppfppf)
tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, stm32h573i_dk (instable: pppfppf)
tests/subsys/shell/shell/shell.core, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)

Total: 100 test(s) failed out of 9661 tests run
9561 test(s) passed
0 regression(s) on stable test
Recently skipped or filtered: 0

Non reg result analysis on last run:

Failed tests:
   (verdicts: T/p: Passed, F/f: Failed, t:timeout)
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, disco_l475_iot1
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_c031c6
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_f091rc
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_f207zg
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_g474re
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_h743zi
   samples/drivers/led/pwm/sample.drivers.led.led_pwm, nucleo_l073rz
   samples/drivers/watchdog/sample.drivers.watchdog.stm32h7_wwdg, nucleo_h743zi
   samples/modules/cmsis_dsp/moving_average/sample.modules.cmsis_dsp.moving_average, nucleo_f091rc (instable: pppffpfppfpppppppppppppppppppppppppp)
   samples/psa/its/sample.psa.its.secure_storage.entropy_driver, nucleo_f207zg
   samples/psa/its/sample.psa.its.secure_storage.entropy_driver, nucleo_f429zi
   samples/psa/its/sample.psa.its.secure_storage.entropy_driver, nucleo_h743zi
   samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_f207zg
   samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_f429zi
   samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_g071rb
   samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_h743zi
   samples/psa/its/sample.psa.its.secure_storage.entropy_not_secure, nucleo_l152re
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_driver, nucleo_f207zg
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_driver, nucleo_f429zi
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_driver, nucleo_h743zi
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_f207zg
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_f429zi
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_g071rb
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_h743zi
   samples/psa/persistent_key/sample.psa.persistent_key.secure_storage.entropy_not_secure, nucleo_l152re
   samples/sensor/accel_trig/sample.sensor.accel_trig, stm32f3_disco
   samples/sensor/magn_trig/sample.sensor.magn_trigger, stm32f3_disco
   samples/subsys/nvs/sample.nvs.basic, disco_l475_iot1
   samples/subsys/nvs/sample.nvs.basic, nucleo_g474re
   samples/subsys/nvs/sample.nvs.basic, nucleo_l152re
   samples/subsys/nvs/sample.nvs.basic, nucleo_wb55rg
   samples/subsys/nvs/sample.nvs.basic, nucleo_wl55jc
   samples/subsys/nvs/sample.nvs.basic, stm32f3_disco
   samples/subsys/portability/cmsis_rtos_v1/timer_synchronization/sample.portability.cmsis_rtos_v1.timer_synchronization, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
   samples/subsys/portability/cmsis_rtos_v2/timer_synchronization/sample.portability.cmsis_rtos_v2.timer_synchronization, stm32h7s78_dk (instable: pppfppfppfpppp)
   tests/benchmarks/wait_queues/benchmark.wait_queues.dumb, stm32h7s78_dk (instable: pppfpp)
   tests/drivers/clock_control/stm32_clock_configuration/stm32_common_core/drivers.clock.stm32_clock_configuration.common_core.f0_f3.sysclksrc_hsi_8, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
   tests/drivers/clock_control/stm32_clock_configuration/stm32_common_core/drivers.clock.stm32_clock_configuration.common_core.f0_f3.sysclksrc_pll_32_hsi_8, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
   tests/drivers/clock_control/stm32_clock_configuration/stm32_common_devices/drivers.clock.stm32_clock_configuration.common_device.g0.i2c1_sysclk_lptim1_lsi, nucleo_g071rb
   tests/drivers/dma/chan_blen_transfer/drivers.dma.chan_blen_transfer.low_footprint, nucleo_c031c6
   tests/drivers/flash/common/drivers.flash.common.default, nucleo_f207zg
   tests/drivers/flash/common/drivers.flash.common.default, nucleo_g071rb
   tests/drivers/flash/common/drivers.flash.common.default, nucleo_l152re
   tests/drivers/flash/common/drivers.flash.common.stm32, nucleo_f207zg
   tests/drivers/flash/common/drivers.flash.common.stm32, nucleo_l152re
   tests/drivers/ipm/drivers.ipc.mailbox, nucleo_f746zg (instable: pppfppfppfppfppppppppppppppppppppppp)
   tests/drivers/spi/dt_spec/drivers.spi.dt_spec, nucleo_f091rc (instable: pppfpffppfpppppppppppppppppppppppppp)
   tests/drivers/uart/uart_async_api/drivers.uart.async_api, nucleo_c031c6
   tests/kernel/context/kernel.context.minimallibc, stm32h7s78_dk
   tests/kernel/mem_heap/k_heap_api/kernel.k_heap_api, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)
   tests/kernel/pending/kernel.objects, nucleo_f091rc
   tests/kernel/timer/timepoints/kernel.timer.timepoints, stm32h7s78_dk (instable: pppfppfppfpppp)
   tests/lib/c_lib/common/libraries.libc.common, nucleo_f091rc
   tests/lib/c_lib/common/libraries.libc.common.picolibc, nucleo_f091rc
   tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cf32.fpu, nucleo_h743zi
   tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cf64, nucleo_h743zi
   tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.cf64.fpu, nucleo_h743zi
   tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.rf64, nucleo_h743zi
   tests/lib/cmsis_dsp/transform/libraries.cmsis_dsp.transform.rf64.fpu, nucleo_h743zi
   tests/lib/spsc_pbuf/libraries.spsc_pbuf.utilization, nucleo_f103rb
   tests/net/dhcpv6/net.dhcpv6, nucleo_f429zi (instable: pppfppfppfpppppppppppppppppppppppppp)
   tests/net/lib/prometheus/formatter/prometheus.formatter, nucleo_f429zi
   tests/net/lib/prometheus/formatter/prometheus.formatter, stm32h573i_dk
   tests/subsys/ipc/pbuf/ipc.icmsg_pbuf, nucleo_f091rc
   tests/subsys/logging/log_frontend_stmesp_demux/debug.coresight.stp_demux_max_utilization, stm32h7s78_dk (instable: pppffpfppfpppp)
   tests/subsys/logging/log_immediate/logging.immediate.clean_output, nucleo_f091rc
   tests/subsys/logging/log_output/logging.output, nucleo_f091rc
   tests/subsys/logging/log_output/logging.output.thread_id, nucleo_f091rc (instable: pppffpfppfpppp)
   tests/subsys/rtio/workq/rtio.workq, nucleo_f091rc (instable: pfpfppfppfpppppppppppppppppppppppppppp)
   tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_f207zg
   tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_f429zi
   tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_g071rb
   tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_h743zi
   tests/subsys/secure_storage/psa/crypto/secure_storage.psa.crypto.secure_storage, nucleo_l152re
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, disco_l475_iot1
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_f103rb (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_f207zg
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_f429zi
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_g071rb
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_g474re (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_h743zi
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_l152re
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_wb55rg
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_wba55cg
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, nucleo_wl55jc (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage, stm32h573i_dk (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, disco_l475_iot1
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f091rc
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f103rb (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f207zg
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_f429zi
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_g071rb
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_g474re (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_h743zi
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_l152re
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_wb55rg
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_wba55cg
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, nucleo_wl55jc (instable: pppfppf)
   tests/subsys/secure_storage/psa/its/secure_storage.psa.its.secure_storage.custom.transform, stm32h573i_dk (instable: pppfppf)
   tests/subsys/shell/shell/shell.core, nucleo_f091rc (instable: pppfppfppfpppppppppppppppppppppppppp)

Total: 100 test(s) failed out of 9661 tests run
       9561 test(s) passed
       0 regression(s) on stable test
Recently skipped or filtered: 0

Signed-off-by: Erwan Gouriou <erwan.gouriou@st.com>
@hakehuang hakehuang merged commit ccabfa9 into zephyrproject-rtos:master Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants