Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The wrong Python version can be detected on Windows #11103

Closed
SebastianBoe opened this issue Nov 5, 2018 · 0 comments · Fixed by #11306
Closed

The wrong Python version can be detected on Windows #11103

SebastianBoe opened this issue Nov 5, 2018 · 0 comments · Fixed by #11306
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@SebastianBoe
Copy link
Collaborator

When a Windows-user (this does not affect Linux) has both Python2 and Python3 on path, and Python2 is earlier on path, the wrong python will be detected.

NB: Zephyr only supports Python 3.

Until this is resolved users should either re-order Python2's location on path, or invoke CMake while setting the CMake variable PYTHON_EXECUTABLE.
@SebastianBoe SebastianBoe added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Build System labels Nov 5, 2018
@SebastianBoe SebastianBoe mentioned this issue Nov 12, 2018
Merged
SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Nov 12, 2018
@SebastianBoe
cmake: Copy CMake's FindPythonInterp.cmake into the repo
df843ce 
Copy the 3.8.2 version of FindPythonInterp.cmake into the repo so that
we can patch it and fix zephyrproject-rtos#11103.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Nov 12, 2018
@SebastianBoe
cmake: Fix python version detection
0eeafcc 
The 'FindPythonInterp' that is distributed with CMake 3.8 is affected
by bug: zephyrproject-rtos#11103

To work around this, until we upgrade to 3.13, we copy and patch the
3.8 version of 'FindPythonInterp' into the Zephyr repository.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
carlescufi pushed a commit that referenced this issue Nov 20, 2018
@SebastianBoe @carlescufi
cmake: Copy CMake's FindPythonInterp.cmake into the repo
db63841 
Copy the 3.8.2 version of FindPythonInterp.cmake into the repo so that
we can patch it and fix #11103.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
carlescufi pushed a commit that referenced this issue Nov 20, 2018
@SebastianBoe @carlescufi
cmake: Fix python version detection
985b93a 
The 'FindPythonInterp' that is distributed with CMake 3.8 is affected
by bug: #11103

To work around this, until we upgrade to 3.13, we copy and patch the
3.8 version of 'FindPythonInterp' into the Zephyr repository.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@SebastianBoe SebastianBoe mentioned this issue Dec 12, 2018
Merged
@E3V3A E3V3A mentioned this issue Apr 9, 2019
Closed
@tejlmand tejlmand mentioned this issue Feb 5, 2020
Merged
This was referenced Apr 9, 2020
Closed
Closed
tejlmand added a commit to tejlmand/zephyr that referenced this issue Apr 13, 2020
@tejlmand
cmake: now using find_package(python3) from CMake to located python3
8e04a87 
Fixes: zephyrproject-rtos#23922, zephyrproject-rtos#24252, zephyrproject-rtos#11103

This commit switches to use the find_package(Python3) introduced with
CMake 3.12.

This removes the need for a Zephyr backport of Python detection module.

The search order for Python3 is following CMake search order and can be
controlled through CMake flags (See CMake documentation).

Default it will use the Python version found in PATH.
If multiple Python3 versions are found in PATH, the newest version will
be selected (Can be controlled using `Python3_FIND_STRATEGY`)

Using find_package(Python3) also ensures Python2.7 will never be
selected, issue zephyrproject-rtos#11103, which was re-introduced in Zephyr.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand mentioned this issue Apr 13, 2020
Merged
nashif pushed a commit that referenced this issue Apr 13, 2020
@tejlmand @nashif
cmake: now using find_package(python3) from CMake to located python3
b5a612d 
Fixes: #23922, #24252, #11103

This commit switches to use the find_package(Python3) introduced with
CMake 3.12.

This removes the need for a Zephyr backport of Python detection module.

The search order for Python3 is following CMake search order and can be
controlled through CMake flags (See CMake documentation).

Default it will use the Python version found in PATH.
If multiple Python3 versions are found in PATH, the newest version will
be selected (Can be controlled using `Python3_FIND_STRATEGY`)

Using find_package(Python3) also ensures Python2.7 will never be
selected, issue #11103, which was re-introduced in Zephyr.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
avisconti pushed a commit to avisconti/zephyr that referenced this issue Apr 15, 2020
@tejlmand @avisconti
cmake: now using find_package(python3) from CMake to located python3
03ee38a 
Fixes: zephyrproject-rtos#23922, zephyrproject-rtos#24252, zephyrproject-rtos#11103

This commit switches to use the find_package(Python3) introduced with
CMake 3.12.

This removes the need for a Zephyr backport of Python detection module.

The search order for Python3 is following CMake search order and can be
controlled through CMake flags (See CMake documentation).

Default it will use the Python version found in PATH.
If multiple Python3 versions are found in PATH, the newest version will
be selected (Can be controlled using `Python3_FIND_STRATEGY`)

Using find_package(Python3) also ensures Python2.7 will never be
selected, issue zephyrproject-rtos#11103, which was re-introduced in Zephyr.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@tejlmand @hakehuang
cmake: now using find_package(python3) from CMake to located python3
fbf9365 
Fixes: zephyrproject-rtos#23922, zephyrproject-rtos#24252, zephyrproject-rtos#11103

This commit switches to use the find_package(Python3) introduced with
CMake 3.12.

This removes the need for a Zephyr backport of Python detection module.

The search order for Python3 is following CMake search order and can be
controlled through CMake flags (See CMake documentation).

Default it will use the Python version found in PATH.
If multiple Python3 versions are found in PATH, the newest version will
be selected (Can be controlled using `Python3_FIND_STRATEGY`)

Using find_package(Python3) also ensures Python2.7 will never be
selected, issue zephyrproject-rtos#11103, which was re-introduced in Zephyr.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand mentioned this issue Nov 6, 2020
Closed
@tejlmand tejlmand mentioned this issue Mar 27, 2023
Closed
@tejlmand tejlmand mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Fix python version detection SebastianBoe/zephyr
1 participant
@SebastianBoe