Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrfx_clock.c functions are not available with CONFIG_NRFX_CLOCK #19031

Closed
lanvis opened this issue Sep 9, 2019 · 4 comments
Closed

nrfx_clock.c functions are not available with CONFIG_NRFX_CLOCK #19031

lanvis opened this issue Sep 9, 2019 · 4 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: low Low impact/importance bug

Comments

@lanvis
Copy link

lanvis commented Sep 9, 2019

Issue
nrfx_clock.c functions are not defined with CONFIG_NRFX_CLOCK and therefore cannot configure RTC at run time.

To Reproduce
1.13.99: Add CONFIG_NRFX_CLOCK to a nrf52840 board sample project file then see if function nrfx_clock_lfclk_stop() is available (no link error).
2.0.99 : ?? nrfx_clock.c has been removed from source tree.

Expected behavior
1.13.99 Functions in nrfx_clock.c are not available when CONFIG_NRFX_CLOCK is defined in proj file.
2.0.99 cmake error when defined .. found that nrfx_clock.c is no longer included as a source file and its functions (e.g. nrfx_clcock_lfclk_stop() are no where to be found).

Impact
Cannot configure RTC clock at run time.

Screenshots or console output

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: Zephyr SDK 0.10.3
  • Board nrf52840_pca10056
    -Zephyr 1.13.99 & 2.0.99

Additional context
None ...

@lanvis lanvis added the bug The issue is a bug, or the PR is fixing a bug label Sep 9, 2019
@carlescufi carlescufi added the platform: nRF Nordic nRFx label Sep 10, 2019
@anangl
Copy link
Member

anangl commented Sep 10, 2019

@lanvis Now that #18895 is merged the issue should be fixed. Could you please check and confirm it? The problem was that since the NRFX_CLOCK option had no prompt, it was impossible to modify it from the application configuration file - the CONFIG_NRFX_CLOCK=y statement was simply ignored (it was the case also in earlier versions of Zephyr, so if it worked for you earlier, it was by chance - some other Kconfig option must have selected NRFX_CLOCK).

@lanvis
Copy link
Author

lanvis commented Sep 10, 2019

I don't think so because in 2.0.99, the nrfx_clock.c is not in the source tree. This function includes all of the methods (procs) to change the RTC configuration at run time. I looked at your commits and didn't see it.

@ioannisg ioannisg added the priority: medium Medium impact/importance bug label Sep 10, 2019
@carlescufi
Copy link
Member

@lanvis that is because we have moved nrfx to a separate module. It's here: https://github.com/zephyrproject-rtos/hal_nordic/blob/master/nrfx/drivers/src/nrfx_clock.c

Just update to the latest master and then run west update. You will find the files in modules/hal/nordic/nrfx/drivers/src.

@carlescufi carlescufi added priority: low Low impact/importance bug and removed priority: medium Medium impact/importance bug labels Sep 10, 2019
@anangl
Copy link
Member

anangl commented Nov 13, 2019

Resolved by #18895.

@anangl anangl closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants