modules: Facilitate the use of nrfx drivers #18895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a consistent way of enabling particular instances of peripherals in nrfx drivers through options defined in modules/Kconfig.nordic, to make the usage of nrfx drivers in Zephyr, especially the ones for which there are no Zephyr driver shims (yet), easier. Jira: NCSDK-2744 Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl
added
area: Drivers
platform: nRF
anangl
requested review from
ulfalizer,
ioannisg,
kl-cruz,
carlescufi,
nordic-krch and
Mierunski
ulfalizer
reviewed
Sep 4, 2019
ulfalizer
reviewed
Sep 4, 2019
|
All checks are passing now. Review history of this comment for details about previous failed status. |
The options are given prompts, so that they become accessible from application configuration files and visible in menuconfig, and they are complemented with proper dependencies, so that only the relevant ones for the selected SoC are made available. Jira: NCSDK-2744 Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl
force-pushed
the
facilitate_nrfx_drivers_use
branch
from
df3a702 to
70e3d25
Compare
anangl
changed the title
Quite a few nrfx drivers are missing corresponding Kconfig options that would enable their use in Zephyr applications. Add such options, to facilitate the use of nRF peripherals for which there are no Zephyr driver shims or even suitable APIs. Jira: NCSDK-2744 Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl
force-pushed
the
facilitate_nrfx_drivers_use
branch
from
70e3d25 to
4ef25a0
Compare
|
In the hal_nordic module I added a protection against including particular nrfx_config_*.h files directly, not through the common nrfx_config.h. I also moved the change done to the west manifest to a separate commit, for clarity. |
anangl
changed the title
Update the module revision so that the following commits become effective: * nrfx_config: Use common mappings of Kconfig options to nrfx macros * nrfx_config: Unify the way of enabling instances in nrfx drivers * nrfx_config: Add missing mappings of Kconfig option symbols * CMakeLists: Add missing inclusions of driver implementation files The above changes require a minor correction in the nrf91/soc.h file, so it is also modified in this commit. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
anangl
force-pushed
the
facilitate_nrfx_drivers_use
branch
from
4ef25a0 to
5316f04
Compare
|
Updated west.yml with the proper revision of the hal_nordic module as zephyrproject-rtos/hal_nordic#2 has been merged. |
anangl
removed
Blocked
kl-cruz
approved these changes
Sep 10, 2019
carlescufi
approved these changes
Sep 10, 2019
This was referenced Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits is intended to facilitate the use of nrfx drivers, and hence nRF peripherals, in Zephyr applications, especially in cases when there are no corresponding Zephyr driver shims.
Requires zephyrproject-rtos/hal_nordic#2 to go in first.