Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPP management don't build #23420

Closed
nandojve opened this issue Mar 12, 2020 · 0 comments · Fixed by #23711
Closed

PPP management don't build #23420

nandojve opened this issue Mar 12, 2020 · 0 comments · Fixed by #23711
Assignees
@jukkar
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@nandojve
Copy link
Member

Describe the bug
samples/net/gsm_modem with CONFIG_NET_L2_PPP_MGMT=y don't build.

To Reproduce

1- With configuration and overlay from ee5bf09c2106065623d46069c4804f0ae7e73c0a
2- Add CONFIG_NET_L2_PPP_MGMT=y on configuration
3- west build -b sam4e_xpro samples/net/gsm_modem

Screenshots or console output

/home/gfbudke/zephyr-sdk-0.11.2/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/9.2.0/../../../../arm-zephyr-eabi/bin/ld: zephyr/subsys/net/l2/ppp/libsubsys__net__l2__ppp.a(ppp_l2.c.obj): in function `carrier_on':
/home/gfbudke/zephyros/mainline/zephyr/subsys/net/l2/ppp/ppp_l2.c:270: undefined reference to `ppp_mgmt_raise_carrier_on_event'
/home/gfbudke/zephyr-sdk-0.11.2/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/9.2.0/../../../../arm-zephyr-eabi/bin/ld: zephyr/subsys/net/l2/ppp/libsubsys__net__l2__ppp.a(ppp_l2.c.obj): in function `carrier_off':
/home/gfbudke/zephyros/mainline/zephyr/subsys/net/l2/ppp/ppp_l2.c:292: undefined reference to `ppp_mgmt_raise_carrier_off_event'
collect2: error: ld returned 1 exit status

Environment:

  • Debian 10
  • Zephyr SDK 0.11.2
  • mainline version
  • ee5bf09c2106065623d46069c4804f0ae7e73c0a
@nandojve nandojve added the bug The issue is a bug, or the PR is fixing a bug label Mar 12, 2020
@jukkar jukkar self-assigned this Mar 12, 2020
@jukkar jukkar added area: Networking priority: low Low impact/importance bug labels Mar 12, 2020
@zephyrproject-rtos zephyrproject-rtos deleted a comment from nandojve Mar 12, 2020
chrta added a commit to lemonbeat/zephyr that referenced this issue Mar 24, 2020
@chrta
net: ppp: Implement missing ppp mgmt functions
482d8b3 
The functions ppp_mgmt_raise_carrier_on/off_event() were not
implemented, but already documeted in the header net/ppp.h

Fixes zephyrproject-rtos#23420

Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>
@chrta chrta mentioned this issue Mar 24, 2020
Merged
MaureenHelm pushed a commit that referenced this issue Mar 24, 2020
@chrta @MaureenHelm
net: ppp: Implement missing ppp mgmt functions
a401aef 
The functions ppp_mgmt_raise_carrier_on/off_event() were not
implemented, but already documeted in the header net/ppp.h

Fixes #23420

Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Apr 30, 2020
@chrta @hakehuang
net: ppp: Implement missing ppp mgmt functions
b8c05d8 
The functions ppp_mgmt_raise_carrier_on/off_event() were not
implemented, but already documeted in the header net/ppp.h

Fixes zephyrproject-rtos#23420

Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: ppp: Implement missing ppp mgmt functions lemonbeat/zephyr
2 participants
@jukkar @nandojve