Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Cortex M Systick driver broken by merge of #24012 #24347

Closed
b0661 opened this issue Apr 14, 2020 · 1 comment · Fixed by #24348
Closed

Application Cortex M Systick driver broken by merge of #24012 #24347

b0661 opened this issue Apr 14, 2020 · 1 comment · Fixed by #24348
Assignees
Labels
area: ARM ARM (32-bit) Architecture area: Timer Timer bug The issue is a bug, or the PR is fixing a bug

Comments

@b0661
Copy link
Collaborator

b0661 commented Apr 14, 2020

Describe the bug

To get the z_clock_isr() into the vector table now requires to define CONFIG_CORTEX_M_SYSTICK, If CONFIG_CORTEX_M_SYSTICK is defined the standard Zephyr driver is added to the zephyr lib. The application driver and the Zephyr driver now are both providing the same symbols (that were defined weak just for the purpose to allow for application drivers - see history of the vector table file).

To Reproduce
See above

Expected behavior
Allow application systick driver

Impact
Showstopper - application does not compile and needs a special systick driver.

Screenshots or console output
N/A

Environment (please complete the following information):

Additional context
N/A

@b0661 b0661 added the bug The issue is a bug, or the PR is fixing a bug label Apr 14, 2020
@carlescufi carlescufi added area: ARM ARM (32-bit) Architecture area: Timer Timer labels Apr 14, 2020
@stephanosio
Copy link
Member

Initial discussion at 4364f2d

b0661 added a commit to b0661/zephyr that referenced this issue Apr 14, 2020
The selection of the Cortex M systick driver to be used as a system
clock driver is controlled by CONFIG_CORTEX_M_SYSTICK.

To replace it by another driver CONFIG_CORTEX_M_SYSTICK must be set
to 'n'. Unfortunately this also controls the interrupt vector for
the systick interrupt. It is now routed to z_arm_exc_spurious.

Remove the dependecy on CONFIG_CORTEX_M_SYSTICK and route to
z_clock_isr as it was before zephyrproject-rtos#24012.

Fixes zephyrproject-rtos#24347

Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
ioannisg pushed a commit that referenced this issue Apr 15, 2020
The selection of the Cortex M systick driver to be used as a system
clock driver is controlled by CONFIG_CORTEX_M_SYSTICK.

To replace it by another driver CONFIG_CORTEX_M_SYSTICK must be set
to 'n'. Unfortunately this also controls the interrupt vector for
the systick interrupt. It is now routed to z_arm_exc_spurious.

Remove the dependecy on CONFIG_CORTEX_M_SYSTICK and route to
z_clock_isr as it was before #24012.

Fixes #24347

Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
avisconti pushed a commit to avisconti/zephyr that referenced this issue Apr 15, 2020
The selection of the Cortex M systick driver to be used as a system
clock driver is controlled by CONFIG_CORTEX_M_SYSTICK.

To replace it by another driver CONFIG_CORTEX_M_SYSTICK must be set
to 'n'. Unfortunately this also controls the interrupt vector for
the systick interrupt. It is now routed to z_arm_exc_spurious.

Remove the dependecy on CONFIG_CORTEX_M_SYSTICK and route to
z_clock_isr as it was before zephyrproject-rtos#24012.

Fixes zephyrproject-rtos#24347

Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
The selection of the Cortex M systick driver to be used as a system
clock driver is controlled by CONFIG_CORTEX_M_SYSTICK.

To replace it by another driver CONFIG_CORTEX_M_SYSTICK must be set
to 'n'. Unfortunately this also controls the interrupt vector for
the systick interrupt. It is now routed to z_arm_exc_spurious.

Remove the dependecy on CONFIG_CORTEX_M_SYSTICK and route to
z_clock_isr as it was before zephyrproject-rtos#24012.

Fixes zephyrproject-rtos#24347

Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARM ARM (32-bit) Architecture area: Timer Timer bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants