samples/subsys/mgmt/mcumgr/smp_svr: should enable BT and FS for nrf52 boards #24442
Assignees
Labels
area: mcumgr
area: Samples
Samples
bug
The issue is a bug, or the PR is fixing a bug
Regression
Something, which was working, does not anymore
Comments
nvlsianpu
added
bug
|
The sample was intentionally split up so that prj.conf contained only the common configuration set and transport specific configuration is contained in overlay configurations. To enable bluetooth transport, you'll need to add one of the bt overlay configs in the build command, like so: As for the missing FS command set, that's a bug and I will make a PR to fix that. |
|
I supposed that this sample is building with required features enables out of the box for these boards. |
nvlsianpu
added a commit
to nvlsianpu/zephyr
that referenced
this issue
Apr 17, 2020
Added default configuration files for nrf5 boards so the sample is building with expected features for these boards. Would be greater to use OVERLAY_CONFIG instead of files addition, but that doesn't work from CMakeLists.txt scope. fixes zephyrproject-rtos#24442 Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
carlescufi
pushed a commit
that referenced
this issue
Apr 20, 2020
Added default configuration files for nrf5 boards so the sample is building with expected features for these boards. Would be greater to use OVERLAY_CONFIG instead of files addition, but that doesn't work from CMakeLists.txt scope. fixes #24442 Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
hakehuang
pushed a commit
to hakehuang/zephyr
that referenced
this issue
Jun 20, 2020
Added default configuration files for nrf5 boards so the sample is building with expected features for these boards. Would be greater to use OVERLAY_CONFIG instead of files addition, but that doesn't work from CMakeLists.txt scope. fixes zephyrproject-rtos#24442 Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The sample used to build with BT transport and FS command set enabled for out-of the box build. After merge #20983 its stops.
To Reproduce
Steps to reproduce the behavior:
1.
west build -d build/smp_svr -b nrf52840dk_nrf52840 ./zephyr/samples/subsys/mgmt/mcumgr/smp_svr/Expected behavior
These feature should be enabled by default for nrf52 targets
Impact
bad user experience
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: