Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soc: apollo_lake: Disabling I2C support is not possible #25204

Closed
jhedberg opened this issue May 11, 2020 · 0 comments · Fixed by #25205
Closed

soc: apollo_lake: Disabling I2C support is not possible #25204

jhedberg opened this issue May 11, 2020 · 0 comments · Fixed by #25205
Assignees
@jhedberg
Labels
area: I2C bug The issue is a bug, or the PR is fixing a bug

Comments

@jhedberg
Copy link
Member

Trying to set CONFIG_I2C=n in the application's prj.conf results in the following:

warning: HAS_I2C_DW (defined at drivers/i2c/Kconfig.dw:6) has direct dependencies I2C with value n, but is currently being y-selected by the following symbols:
 - SOC_APOLLO_LAKE (defined at soc/x86/apollo_lake/Kconfig.soc:4), with value y, direct dependencies <choice> (value: y), and select condition <choice> (value: y)

error: Aborting due to Kconfig warnings
@jhedberg jhedberg added bug The issue is a bug, or the PR is fixing a bug area: I2C labels May 11, 2020
@jhedberg jhedberg self-assigned this May 11, 2020
@jhedberg jhedberg mentioned this issue May 11, 2020
Merged
carlescufi pushed a commit that referenced this issue May 11, 2020
@carlescufi
soc: x86: apollo_lake: Make it possible to disable I2C support
1108611 
Make it possible for an application to set CONFIG_I2C=n if it wants.
The unconditional select was making this impossible due to resulting
unmet dependencies.

This is also in line with what some other SoC definitions do with I2C.

Fixes #25204

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@hakehuang
soc: x86: apollo_lake: Make it possible to disable I2C support
8da398a 
Make it possible for an application to set CONFIG_I2C=n if it wants.
The unconditional select was making this impossible due to resulting
unmet dependencies.

This is also in line with what some other SoC definitions do with I2C.

Fixes zephyrproject-rtos#25204

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhedberg jhedberg

Labels
area: I2C bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

soc: x86: apollo_lake: Make it possible to disable I2C support jhedberg/zephyr
1 participant
@jhedberg