Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESWiFi does not populate info about remote when invoking callback #25621

Closed
bwasim opened this issue May 26, 2020 · 0 comments · Fixed by #25209
Closed

ESWiFi does not populate info about remote when invoking callback #25621

bwasim opened this issue May 26, 2020 · 0 comments · Fixed by #25209
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@bwasim
Copy link
Contributor

bwasim commented May 26, 2020

Describe the bug
It was observed that telnet does not work with on the STM32 disco IOT board which has support for "esWiFi" driver. Upon further inspection, it was found that the driver does not populate information about the remote, including port and ip which causes the NET stack to fail.

To Reproduce
Steps to reproduce the behavior:

  1. west build -p auto -b disco_l475_iot1 samples\net\telnet
  2. See error

Expected behavior
WiFi driver should pass remote information when invoking CB so that NET stack doesn't fail.

Environment (please complete the following information):

  • OS: Windows
  • Toolchain: GNU Arm Toolchain
  • V2.3.0 RC
@bwasim bwasim added the bug The issue is a bug, or the PR is fixing a bug label May 26, 2020
bwasim added a commit to bwasim/zephyr that referenced this issue May 26, 2020
@bwasim
drivers: wifi: eswifi: Fully populate sockaddr_in on async msg
d0d8162 
Updating the eswifi driver to provide port information (along with
IP / net context) whenever an async message is received. This is
needed to fully populate the "remote" info in "net_context"
required whenever net_context_send is called.

Also adding code to populate "remote" info in "net_context"..

Tested with STM32 disco IOT kit. Fixes zephyrproject-rtos#25621

Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com>
@bwasim bwasim mentioned this issue May 26, 2020
Merged
@carlescufi carlescufi mentioned this issue May 26, 2020
Closed
carlescufi pushed a commit that referenced this issue May 26, 2020
@bwasim @carlescufi
drivers: wifi: eswifi: Fully populate sockaddr_in on async msg
64d5192 
Updating the eswifi driver to provide port information (along with
IP / net context) whenever an async message is received. This is
needed to fully populate the "remote" info in "net_context"
required whenever net_context_send is called.

Also adding code to populate "remote" info in "net_context"..

Tested with STM32 disco IOT kit. Fixes #25621

Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com>
krip-tip pushed a commit to krip-tip/zephyr-local that referenced this issue May 30, 2020
@bwasim
drivers: wifi: eswifi: Fully populate sockaddr_in on async msg
cdb45b7 
Updating the eswifi driver to provide port information (along with
IP / net context) whenever an async message is received. This is
needed to fully populate the "remote" info in "net_context"
required whenever net_context_send is called.

Also adding code to populate "remote" info in "net_context"..

Tested with STM32 disco IOT kit. Fixes zephyrproject-rtos#25621

Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Making telnet functional with esWiFi bwasim/zephyr
1 participant
@bwasim